Re: [Qemu-arm] [PATCH v2 06/26] armv7m: fix I and F flag handling

[Peter Maydell]

On 17 December 2015 at 14:39, Peter Maydell <address@hidden> wrote:
> On 3 December 2015 at 00:18, Michael Davidsaver <address@hidden> wrote:
>> Despite having the same notation, these bits
>> have completely different meaning than -AR.
>>
>> Use armv7m_excp_running_prio() and the highest
>> pending exception priority to determine
>> if the pending exception can interrupt preempt.
>> ---
>>  target-arm/cpu.c | 16 ++++++----------
>>  1 file changed, 6 insertions(+), 10 deletions(-)
>
> Reviewed-by: Peter Maydell <address@hidden>

...except this breaks the build for linux-user:

  LINK  arm-linux-user/qemu-arm
target-arm/cpu.o: In function `arm_v7m_cpu_exec_interrupt':
/home/petmay01/linaro/qemu-from-laptop/qemu/target-arm/cpu.c:316:
undefined reference to `armv7m_excp_running_prio'

because the function you're calling here is in armv7m_nvic.c,
which isn't compiled into the linux-user binary.

thanks
-- PMM