Re: [Qemu-arm] [Qemu-devel] [PATCH v2 01/13] hw: Don't use hw_error() for machine initialization errors

[Thomas Huth]

On 17/12/15 13:19, Markus Armbruster wrote:
> Printing CPU registers is not helpful during machine initialization.
> Moreover, these are straightforward configuration or "can get
> resources" errors, so dumping core isn't appropriate either.  Replace
> hw_error() by error_report(); exit(1).  Matches how we report these
> errors in other machine initializations.
> 
> Cc: Richard Henderson <address@hidden>
> Cc: address@hidden
> Cc: address@hidden
> Cc: Guan Xuetao <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Peter Maydell <address@hidden>
> ---
>  hw/alpha/dp264.c          | 11 ++++++-----
>  hw/arm/highbank.c         |  6 ++++--
>  hw/char/exynos4210_uart.c |  9 ++++++---
>  hw/m68k/an5206.c          |  4 +++-
>  hw/ppc/mac_newworld.c     | 11 ++++++-----
>  hw/ppc/mac_oldworld.c     | 16 +++++++++-------
>  hw/ppc/prep.c             | 11 +++++++----
>  hw/unicore32/puv3.c       | 10 +++++++---
>  8 files changed, 48 insertions(+), 30 deletions(-)
> 

Reviewed-by: Thomas Huth <address@hidden>