[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH] Use error_fatal to simplify obvious
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH] Use error_fatal to simplify obvious fatal errors |
|
Date: |
Thu, 10 Dec 2015 14:41:27 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Markus Armbruster <address@hidden> writes:
> Paolo Bonzini <address@hidden> writes:
>
>> On 10/12/2015 11:19, Markus Armbruster wrote:
>>> + object_property_set_int(OBJECT(cpu), ZYNQ_BOARD_MIDR, "midr",
>>> + &error_fatal);object_property_set_int(OBJECT(cpu),
>>> + MPCORE_PERIPHBASE,
>>> + "reset-cbar",
>>> + &error_fatal);object_property_set_bool(OBJECT(cpu),
>>> + true,
>>> + "realized",
>>> + &error_fatal);
>>
>> Something went wrong here. :)
>
> Once again I demonstrate incompetence at proofreading my own patches %-}
>
> No idea what happened. I'll fix it.
Coccinelle bug. If I append '//' to the relevant line in the semantic
patch, I get
+
&error_fatal);//object_property_set_int(OBJECT(cpu),
Oopsie :)
[...]