[Pspp-cvs] pspp doc/ChangeLog doc/statistics.texi src/lang...

[John Darrington]

CVSROOT:        /sources/pspp
Module name:    pspp
Changes by:     John Darrington <jmd>   07/07/28 00:40:53

Modified files:
        doc            : ChangeLog statistics.texi 
        src/language/stats: ChangeLog t-test.q 
        tests          : ChangeLog 
        tests/command  : t-test-1-indep-val.sh 

Log message:
        Fix bug #19604. T-Test documentation now matches code; code matches 
spss behaviour

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/pspp/doc/ChangeLog?cvsroot=pspp&r1=1.47&r2=1.48
http://cvs.savannah.gnu.org/viewcvs/pspp/doc/statistics.texi?cvsroot=pspp&r1=1.16&r2=1.17
http://cvs.savannah.gnu.org/viewcvs/pspp/src/language/stats/ChangeLog?cvsroot=pspp&r1=1.56&r2=1.57
http://cvs.savannah.gnu.org/viewcvs/pspp/src/language/stats/t-test.q?cvsroot=pspp&r1=1.25&r2=1.26
http://cvs.savannah.gnu.org/viewcvs/pspp/tests/ChangeLog?cvsroot=pspp&r1=1.99&r2=1.100
http://cvs.savannah.gnu.org/viewcvs/pspp/tests/command/t-test-1-indep-val.sh?cvsroot=pspp&r1=1.12&r2=1.13

Patches:
Index: doc/ChangeLog
===================================================================
RCS file: /sources/pspp/pspp/doc/ChangeLog,v
retrieving revision 1.47
retrieving revision 1.48
diff -u -b -r1.47 -r1.48
--- doc/ChangeLog       18 Jul 2007 03:17:04 -0000      1.47
+++ doc/ChangeLog       28 Jul 2007 00:40:52 -0000      1.48
@@ -1,3 +1,8 @@
+2007-07-28 John Darrington <address@hidden>
+
+       * statistics.texi: Made the documentation for T-TEST match 
+       the behaviour.
+
 2007-07-17  Ben Pfaff  <address@hidden>
 
        * get-commands.pl: Use strict and all warnings.  Simplify

Index: doc/statistics.texi
===================================================================
RCS file: /sources/pspp/pspp/doc/statistics.texi,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -b -r1.16 -r1.17
--- doc/statistics.texi 6 Jun 2007 05:17:48 -0000       1.16
+++ doc/statistics.texi 28 Jul 2007 00:40:52 -0000      1.17
@@ -702,8 +702,8 @@
 If the independent variable is numeric, 
 it is acceptable to specify only one value inside the parentheses.
 If you do this, cases where the independent variable is
-less than  or equal to this value belong to the first group, and cases
-greater than this value belong to the second group.
+greater than or equal to this value belong to the first group, and cases
+less than this value belong to the second group.
 When using this form of the @cmd{GROUPS} subcommand, missing values in
 the independent variable are excluded on a listwise basis, regardless
 of whether @cmd{/MISSING=LISTWISE} was specified.

Index: src/language/stats/ChangeLog
===================================================================
RCS file: /sources/pspp/pspp/src/language/stats/ChangeLog,v
retrieving revision 1.56
retrieving revision 1.57
diff -u -b -r1.56 -r1.57
--- src/language/stats/ChangeLog        27 Jul 2007 21:44:18 -0000      1.56
+++ src/language/stats/ChangeLog        28 Jul 2007 00:40:52 -0000      1.57
@@ -1,3 +1,8 @@
+2007-07-28 John Darrington <address@hidden>
+
+       * t-test.q: Moved the order in which groups are displayed in the 
+       independent samples case, where a cut point is given.
+
 2007-07-27  Ben Pfaff  <address@hidden>
 
        * regression.q (run_regression): Move casereader_destroy call so

Index: src/language/stats/t-test.q
===================================================================
RCS file: /sources/pspp/pspp/src/language/stats/t-test.q,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -b -r1.25 -r1.26
--- src/language/stats/t-test.q 7 Jul 2007 06:14:17 -0000       1.25
+++ src/language/stats/t-test.q 28 Jul 2007 00:40:53 -0000      1.26
@@ -736,8 +736,8 @@
 
   if (gp.criterion == CMP_LE )
     {
-      strcpy(prefix[0],"< ");
-      strcpy(prefix[1],">=");
+      strcpy(prefix[0],">=");
+      strcpy(prefix[1],"<");
       indep_value[0] = gp.v.critical_value;
       indep_value[1] = gp.v.critical_value;
     }
@@ -785,13 +785,13 @@
            {
              if ( count == 0 )
                {
-                 /*  less than ( < )  case */
-                 search_val.f = gp.v.critical_value - 1.0;
+                 /* >= case  */
+                 search_val.f = gp.v.critical_value + 1.0;
                }
              else
                {
-                 /* >= case  */
-                 search_val.f = gp.v.critical_value + 1.0;
+                 /*  less than ( < )  case */
+                 search_val.f = gp.v.critical_value - 1.0;
                }
            }
          else
@@ -1688,7 +1688,6 @@
            }
 
          hsh_insert ( ttpr->group_hash, (void *) gs );
-
        }
     }
 
@@ -1867,7 +1866,7 @@
 
   if ( p->criterion == CMP_LE )
     {
-      /* less-than-or-equal comparision is not meaningfull for
+      /* less-than comparision is not meaningfull for
         alpha variables, so we shouldn't ever arrive here */
       assert(p->indep_width == 0 ) ;
 

Index: tests/ChangeLog
===================================================================
RCS file: /sources/pspp/pspp/tests/ChangeLog,v
retrieving revision 1.99
retrieving revision 1.100
diff -u -b -r1.99 -r1.100
--- tests/ChangeLog     26 Jul 2007 01:52:04 -0000      1.99
+++ tests/ChangeLog     28 Jul 2007 00:40:53 -0000      1.100
@@ -1,3 +1,8 @@
+2007-07-28 John Darrington <address@hidden>
+
+       * command/t-test-1-indep-val.sh: Changed the order of groups in the 
+       summary box to match new behaviour. (Fixes bug #19604).
+
 2007-07-25  Ben Pfaff  <address@hidden>
 
        Fix bug #17100.

Index: tests/command/t-test-1-indep-val.sh
===================================================================
RCS file: /sources/pspp/pspp/tests/command/t-test-1-indep-val.sh,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -b -r1.12 -r1.13
--- tests/command/t-test-1-indep-val.sh 3 Apr 2006 20:07:55 -0000       1.12
+++ tests/command/t-test-1-indep-val.sh 28 Jul 2007 00:40:53 -0000      1.13
@@ -104,8 +104,8 @@
 #===========#==#====#==============#========#
 #     INDEP | N|Mean|Std. Deviation|SE. Mean#
 #===========#==#====#==============#========#
-#DEP < 1.514|11|8.00|         2.864|    .863#
-#    >=1.514|11|9.00|         3.821|   1.152#
+#DEP >=1.514|11|9.00|         3.821|   1.152#
+#    <1.514 |11|8.00|         2.864|    .863#
 #===========#==#====#==============#========#
 2.2 T-TEST.  Independent Samples Test
 
#==============================#=========#===============================================================================#