[Pspp-cvs] pspp/src/language/stats ChangeLog regression.q

[Ben Pfaff]

CVSROOT:        /cvsroot/pspp
Module name:    pspp
Changes by:     Ben Pfaff <blp> 07/07/27 21:44:19

Modified files:
        src/language/stats: ChangeLog regression.q 

Log message:
        (run_regression): Move casereader_destroy call so that it always gets
        called, not just if there was some valid data.  Fixes bug #19581.
        Reviewed by Jason Stover.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/pspp/src/language/stats/ChangeLog?cvsroot=pspp&r1=1.55&r2=1.56
http://cvs.savannah.gnu.org/viewcvs/pspp/src/language/stats/regression.q?cvsroot=pspp&r1=1.56&r2=1.57

Patches:
Index: ChangeLog
===================================================================
RCS file: /cvsroot/pspp/pspp/src/language/stats/ChangeLog,v
retrieving revision 1.55
retrieving revision 1.56
diff -u -b -r1.55 -r1.56
--- ChangeLog   25 Jul 2007 04:07:50 -0000      1.55
+++ ChangeLog   27 Jul 2007 21:44:18 -0000      1.56
@@ -1,3 +1,10 @@
+2007-07-27  Ben Pfaff  <address@hidden>
+
+       * regression.q (run_regression): Move casereader_destroy call so
+       that it always gets called, not just if there was some valid
+       data.  Fixes bug #19581.
+       Reviewed by Jason Stover.
+
 2007-07-24  Ben Pfaff  <address@hidden>
 
        * flip.c (struct flip_pgm): Remove `case_size' member (now

Index: regression.q
===================================================================
RCS file: /cvsroot/pspp/pspp/src/language/stats/regression.q,v
retrieving revision 1.56
retrieving revision 1.57
diff -u -b -r1.56 -r1.57
--- regression.q        7 Jul 2007 06:14:17 -0000       1.56
+++ regression.q        27 Jul 2007 21:44:19 -0000      1.57
@@ -1211,7 +1211,6 @@
                 }
           gsl_vector_set (Y, row, case_num (&c, dep_var));
             }
-          casereader_destroy (reader);
          /*
             Now that we know the number of coefficients, allocate space
             and store pointers to the variables that correspond to the
@@ -1238,6 +1237,7 @@
        {
          msg (SE, gettext ("No valid data found. This command was skipped."));
        }
+      casereader_destroy (reader);
     }
   free (indep_vars);
   free (lopts.get_indep_mean_std);