Re: [PATCH v3] pkl: Add data payload param in IO device API

[Mohammad-Reza Nabipoor]

On Thu, Dec 23, 2021 at 06:19:53PM +0100, Jose E. Marchesi wrote:
> 
> Hi Mohammad.
> 
> > 2021-12-23  Mohammad-Reza Nabipoor  <mnabipoor@gnu.org>
> >
> >     * libpoke/ios-dev-file.c (ios_dev_file_open): Add new param `data`.
> >     * libpoke/ios-dev-mem.c (ios_dev_mem_open): Likewise.
> >     * libpoke/ios-dev-nbd.c (ios_dev_nbd_open): Likewise.
> >     * libpoke/ios-dev-proc.c (ios_dev_proc_open): Likewise.
> >     * libpoke/ios-dev-stream.c (ios_dev_stream_open): Likewise.
> >     * libpoke/ios-dev-zero.c (ios_dev_zero_open): Likewise.
> >     * libpoke/ios-dev-sub.c (ios_dev_sub_open): Likewise.
> >     * libpoke/ios-dev.h (struct ios_dev_if): Change `open` to accept new
> >     `data` param. Add new field `data`.
> >     * libpoke/libpoke.h (struct pk_iod_if): Likewise.
> >     * libpoke/ios.c (ios_open): Call `open` with IOD-specific data.
> >     * testsuite/poke.libpoke/foreign-iod.c (iod_op): Add new field
> >     `data`.
> >     (iod_open): Add new param `data`. Report success through `error`.
> >     (iod_if): Add user data.
> >     (USER_DATA): New constant.
> >     (main): Add test for user data.
> > ---
> >
> > Hi, Jose.
> >
> > - I used __attribute__((unused)) to avoid warnings.
> > - Improved the doc string.
> > - In `libpoke/ios-dev.h`, we need an empty line to be consistent with
> >   the rest of fields.
> >   I removed the empty line in `libpoke/libpoke.h`.
> > - I changed the `user_data` to `data`. IMO it's a better name. As you
> >   said it's a IOD-specific data, not user data.
> 
> Yes I agree, thats a better name.
> 
> Thanks for doing the changes.
> This is OK for master!
> 

Pushed to master.
Thanks.