Re: [PATCH] poke: Improve .set dot command

[Mohammad-Reza Nabipoor]

Hi, Jose.

On Fri, Dec 03, 2021 at 12:31:17AM +0100, Jose E. Marchesi wrote:
> 
> > +
> > +/* Dump current settings.  */
> > +
> > +fun pk_settings_dump = void:
> > +  {
> > +    for (setting in pk_settings.entries)
> > +      {
> > +        if (setting.kind == POKE_SETTING_INT
> > +            || setting.kind == POKE_SETTING_BOOL)
> > +          printf ".set %s %i32d\n", setting.name, setting.getter as int;
> > +        else if (setting.kind == POKE_SETTING_STR)
> > +          printf ".set %s %s\n", setting.name, setting.getter as string;
> 
> Why printing .set in each output line?  I think it would be enough to
> print something like:
> 
> pretty-print 1
> obase 16
> endian little
> auto-map 1
> prompt-maps 1
> oacutoff 66
> odepth 0
> oindent 2
> omaps 0
> omode tree
> doc-viewer less
> 
> Given that, this is OK for master.

I fixed this patch and pushed it to master.
Changes:
  - Removed `.set ` prefix in settings output
  - Dump value of `error-on-warning`
  - Improved doc


Thanks!