Re: [PATCH v2 1/2] libpoke: Add new getter and setters for pk_vals

[Mohammad-Reza Nabipoor]

Hi, Jose.

On Sun, Mar 28, 2021 at 10:03:16PM +0200, Jose E. Marchesi wrote:
> 
> Hi Mohammad.
> 
> This looks great!
> 

Thanks!


> My only comment is: aren't we supposed to update pkc->status in every
> call to libpoke?  In most (all?) of the new functions you added I think
> this is enough:
> 
>   pkc->status = PK_OK;
> 
> But please double-check :)
> 

In every function call that uses a `pkc` instance, yes. This is not
the case for any of these functions.


> Other than that, this is OK for master.
> 

Pushed.


Cheers,
Mohammad-Reza