Re: [PATCH 0/3] Support for E_perm in PVM and IOS

[Egeyar Bagcioglu]

Hi Jose,

I appreciate you asking for our opinions on these patches. I am happy 
with the agreed solution and the first two patches. I have one concern 
and one question about the third, which I shared as a response to the 
concerning email.

I'll be back home from 7pm on. We can discuss the future work then if 
you wish.

Regards
Ege


On 3/27/21 12:37 PM, Jose E. Marchesi wrote:
> Hi peoples!
>
> This little patch series adds support for E_perm and IOS_EPERM to PVM
> and IO subsystem.
>
> It includes a few tests (including situation with "completing bytes"
> as we are discussing in another thread) but please review and chime in
> if you can think on some other non-covered case.
>
> Egeyar, are you ok with the IOS part?
>
> Jose E. Marchesi (3):
>    pvm: add exception E_perm
>    pvm,ios: add IOS_E_PERM and make the PVM to handle it
>    ios: report IOS_EPERM whenever appropriate
>
>   ChangeLog                         | 30 ++++++++++++++++++++++++++++++
>   libpoke/ios.c                     | 30 +++++++++++++++++++++++-------
>   libpoke/ios.h                     |  3 +++
>   libpoke/pkl-rt.pk                 |  3 +++
>   libpoke/pvm.h                     |  4 ++++
>   libpoke/pvm.jitter                |  8 ++++++++
>   testsuite/Makefile.am             |  4 ++++
>   testsuite/poke.map/maps-perm-1.pk |  6 ++++++
>   testsuite/poke.map/maps-perm-2.pk |  6 ++++++
>   testsuite/poke.map/maps-perm-3.pk |  6 ++++++
>   testsuite/poke.map/maps-perm-4.pk | 10 ++++++++++
>   11 files changed, 103 insertions(+), 7 deletions(-)
>   create mode 100644 testsuite/poke.map/maps-perm-1.pk
>   create mode 100644 testsuite/poke.map/maps-perm-2.pk
>   create mode 100644 testsuite/poke.map/maps-perm-3.pk
>   create mode 100644 testsuite/poke.map/maps-perm-4.pk