poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix the behaviour of the flags in file IOD


From: Jose E. Marchesi
Subject: Re: [PATCH] Fix the behaviour of the flags in file IOD
Date: Mon, 15 Mar 2021 00:08:37 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Hi Egeyar.

> This patch replaces the fopen in file IOD with calls to open and
> fdopen to make use of open's wider range of flags. Please review.

This looks so much better than the existing logic!  Thanks for working
on this.

My only comments are:

- We are removing IOS_F_TRUNCATE right?
- Please use C comments, not C++ comments.

Other than that I think this is OK for both master and maint/poke-1.
Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]