[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libpoke/ios-dev-stream.c: free buffer only in read mode
|
From: |
Mohammad-Reza Nabipoor |
|
Subject: |
Re: [PATCH] libpoke/ios-dev-stream.c: free buffer only in read mode |
|
Date: |
Sun, 18 Oct 2020 19:18:16 +0330 |
Hi, Egeyar.
On Sun, Oct 18, 2020 at 12:32:11PM +0200, Egeyar Bagcioglu wrote:
>
> I am no maintainer but I'd like to share my opinion on this. I believe that
> ios_dev_stream has a union for a good reason. It makes it clear that we
> either use a buffer or keep the offset ourselves. Never both at the same
> time... Considering this additional bit of info, I like your original patch.
Thanks for the elaboration.
>
> Having said that, José is the maintainer of poke and he has the last word.
>
> Either way, I think he would ask you to add a ChangeLog regarding your
> changes. If you are not familiar with that, you can check the earlier
> patches to see how to write your change log.
>
Thanks for the advice.
Regards,
Mohammad-Reza