Re: [PATCH] mi: Make sure fd is non-blocking before select+read.

[Jose E. Marchesi]

    >     +
    >        pk_mi_exit_p = 0;
    >     -  while (1)
    >     +
    >     +  while (ret != -1 && ret != -2 && pk_mi_exit_p == 0)
    > 
    > This change in the loop, I don't like.
    > 
    > Before, the logic involving `ret' was only in one place.
    > 
    > With the proposed change the logic is in two places, so if we add a new
    > `ret' value we may have to update _both_ the `while' condition and the
    > if..elseif at the bottom of the function.
    > 
    > Doesn't sound like an improvement to me...
    
    I agree. The other approach would be to call pk_mi_fd_restore_blocking
    before each return. If you like this more, I'll change it.

What about something in the line:

  if (pk_mi_exit_p)
  {
    ret = 1;
    break;
  }
  else if (ret == -1)
  {
    ret = -1;
    break;
  }
  ...
    
    Just want to mention that proper poke error codes, used by all
    functions, would release us from making that suspicious return value
    'translations' in the loop.

Damn right!  Right now each function has its own conventions... it would
be nice to fix that.