[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/6] poke: Remove unneeded header includes.
|
From: |
Jose E. Marchesi |
|
Subject: |
Re: [PATCH 5/6] poke: Remove unneeded header includes. |
|
Date: |
Thu, 07 May 2020 18:44:12 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Hi Tim.
This part is OK.
2020-05-07 Tim Rühsen <address@hidden>
* poke/pk-cmd.c: Do not include gettext.h and pk-term.h.
* poke/pk-def.c: Likewise.
* poke/pk-ios.c: Likewise.
* poke/pk-repl.c: Likewise.
* poke/pk-set.c: Likewise.
* poke/pk-editor.c: Do not include pk-term.h.
* poke/pk-hserver.c: Likewise.
* poke/pk-misc.c: Likewise.
* poke/pk-vm.c: Likewise.
---
ChangeLog | 12 ++++++++++++
poke/pk-cmd.c | 3 ---
poke/pk-def.c | 3 ---
poke/pk-editor.c | 1 -
poke/pk-hserver.c | 1 -
poke/pk-ios.c | 3 ---
poke/pk-misc.c | 1 -
poke/pk-repl.c | 3 ---
poke/pk-set.c | 3 ---
poke/pk-vm.c | 1 -
10 files changed, 12 insertions(+), 19 deletions(-)
diff --git a/poke/pk-cmd.c b/poke/pk-cmd.c
index 6fb9f3f9..93ca7e96 100644
--- a/poke/pk-cmd.c
+++ b/poke/pk-cmd.c
@@ -30,12 +30,9 @@
#include <xalloc.h>
#include <xstrndup.h>
#include <ctype.h>
-#include <gettext.h>
-#define _(str) dgettext (PACKAGE, str)
#include "poke.h"
#include "pk-cmd.h"
-#include "pk-term.h"
#include "pk-utils.h"
/* Table of supported commands. */
diff --git a/poke/pk-def.c b/poke/pk-def.c
index d6977b67..f10e543f 100644
--- a/poke/pk-def.c
+++ b/poke/pk-def.c
@@ -18,12 +18,9 @@
#include <config.h>
#include <string.h>
-#include <gettext.h>
-#define _(str) dgettext (PACKAGE, str)
#include "poke.h"
#include "pk-cmd.h"
-#include "pk-term.h"
static void
print_var_decl (int kind,
diff --git a/poke/pk-editor.c b/poke/pk-editor.c
index c8a966c1..3211f51e 100644
--- a/poke/pk-editor.c
+++ b/poke/pk-editor.c
@@ -28,7 +28,6 @@
#include "poke.h"
#include "pk-cmd.h"
-#include "pk-term.h"
#include "pk-utils.h"
static int
diff --git a/poke/pk-hserver.c b/poke/pk-hserver.c
index 62cf029a..22203d37 100644
--- a/poke/pk-hserver.c
+++ b/poke/pk-hserver.c
@@ -37,7 +37,6 @@
#include "pk-cmd.h"
#include "pk-hserver.h"
#include "pk-repl.h"
-#include "pk-term.h"
/* The app:// protocol defines a maximum length of messages of two
kilobytes. */
diff --git a/poke/pk-ios.c b/poke/pk-ios.c
index 5960df00..1aeabd8c 100644
--- a/poke/pk-ios.c
+++ b/poke/pk-ios.c
@@ -22,15 +22,12 @@
#include <sys/stat.h>
#include <unistd.h>
#include <stdlib.h>
-#include <gettext.h>
-#define _(str) dgettext (PACKAGE, str)
#include <errno.h>
#include <readline.h>
#include "xalloc.h"
#include "poke.h"
#include "pk-cmd.h"
-#include "pk-term.h"
#include "pk-utils.h"
#if HAVE_HSERVER
# include "pk-hserver.h"
diff --git a/poke/pk-misc.c b/poke/pk-misc.c
index 1318163d..8f5b6377 100644
--- a/poke/pk-misc.c
+++ b/poke/pk-misc.c
@@ -27,7 +27,6 @@
#include "poke.h"
#include "pk-cmd.h"
-#include "pk-term.h"
#include "pk-utils.h"
static int
diff --git a/poke/pk-repl.c b/poke/pk-repl.c
index 8845aabb..5f1a5aac 100644
--- a/poke/pk-repl.c
+++ b/poke/pk-repl.c
@@ -26,14 +26,11 @@
#if defined HAVE_READLINE_HISTORY_H
# include <readline/history.h>
#endif
-#include <gettext.h>
-#define _(str) dgettext (PACKAGE, str)
#include "xalloc.h"
#include "xstrndup.h"
#include "poke.h"
#include "pk-cmd.h"
-#include "pk-term.h"
#if HAVE_HSERVER
# include "pk-hserver.h"
#endif
diff --git a/poke/pk-set.c b/poke/pk-set.c
index d1ab0a47..a1342d61 100644
--- a/poke/pk-set.c
+++ b/poke/pk-set.c
@@ -17,8 +17,6 @@
*/
#include <config.h>
-#include <gettext.h>
-#define _(str) dgettext (PACKAGE, str)
#include <assert.h>
#include <string.h>
#include <arpa/inet.h> /* For htonl */
@@ -27,7 +25,6 @@
#include "poke.h"
#include "pk-cmd.h"
-#include "pk-term.h"
#include "pk-utils.h"
static int
diff --git a/poke/pk-vm.c b/poke/pk-vm.c
index ffa50b23..80761e39 100644
--- a/poke/pk-vm.c
+++ b/poke/pk-vm.c
@@ -21,7 +21,6 @@
#include "poke.h"
#include "pk-cmd.h"
-#include "pk-term.h"
#define PK_VM_DIS_UFLAGS "n"
#define PK_VM_DIS_F_NAT 0x1
--
2.26.2
- Re: [PATCH 3/6] ios: Check ios->handler_normalize for memory allocation error., (continued)
[PATCH 4/6] poke: Add new function pk_assert_alloc, Tim Rühsen, 2020/05/07
[PATCH 5/6] poke: Remove unneeded header includes., Tim Rühsen, 2020/05/07
- Re: [PATCH 5/6] poke: Remove unneeded header includes.,
Jose E. Marchesi <=
[PATCH 6/6] ios: Amend OOM message to be consistent everywhere., Tim Rühsen, 2020/05/07
Re: [PATCH 1/6] Check return value of pk_str_concat, Jose E. Marchesi, 2020/05/07