poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Make own set of gnulib modules for libutils


From: Jose E. Marchesi
Subject: Re: [PATCH] Make own set of gnulib modules for libutils
Date: Tue, 05 May 2020 14:27:38 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

    > I would prefer to use the same strategy than for the "main" gnulib,
    > i.e. to have it in the top-level.  We can put it in a directory
    > gl-libutils/.
    
    Sure, it's your project.
    My reason for putting it into libutils/gl (and libutils/gl/m4) is
    self-containment. Not spreading the things that only libutils/ is using
    somewhere around (if possible).

I prefer consistency, in this case.
    
    > 
    >      noinst_SCRIPTS = run
    >     
    >     diff --git a/bootstrap.conf b/bootstrap.conf
    >     index fdf0183d..c1768a26 100644
    >     --- a/bootstrap.conf
    >     +++ b/bootstrap.conf
    >     @@ -16,7 +16,7 @@
    >      # along with this program.  If not, see 
<http://www.gnu.org/licenses/>.
    >     
    >     
    >     -# gnulib modules used by this package.
    >     +# gnulib modules used for this project and in poke/.
    > 
    > 
    > Thats a bit confusing.  I would say something like:
    > "gnulib modules used by libpoke and poke."
    
    I think modules like update-copyright are in their own class - that's
    why I mentioned 'this project'. Not sure how we can split that up in a
    better way.

Ok then "used for this project" would be enough, right?  Why mentioning
also poke/?

    >     + ${GNULIB_SRCDIR}/gnulib-tool --import --lib=libgnu
    > --source-base=libutils/gl --m4-base=libutils/gl/m4 --doc-base=doc
    > --aux-dir=build-aux --lgpl=3 --no-conditional-dependencies --libtool
    > --without-tests --macro-prefix=libutils ${libutils_modules}
    >     +
    > 
    > Why not using the main m4/ directory for libutil?  There is only one
    > configure.ac script in the project.
    
    Also self-containment and bit of being unsure if that is technically the
    same. But yeah, I will do.

Thanks.

Given the points above, this is OK for master.
Thanks for doing this! :)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]