[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fix bugs in dump
|
From: |
Jose E. Marchesi |
|
Subject: |
Re: [PATCH] fix bugs in dump |
|
Date: |
Thu, 21 Nov 2019 11:52:10 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hi John.
This is OK, but for one little thing.
diff --git a/testsuite/poke.cmd/dump-5.pk b/testsuite/poke.cmd/dump-5.pk
new file mode 100644
index 0000000..546feb1
--- /dev/null
+++ b/testsuite/poke.cmd/dump-5.pk
@@ -0,0 +1,10 @@
+/* { dg-do run } */
+/* { dg-data {c*} {0x30 0x31 0x32 0x33 0x34 0x35 0x36 0x37 0x38 0x39 0x41
0x42 0x43 0x44 0x45 0x46 0x47 0x48 0x49} } */
+
+pk_dump_size = 18#B;
+pk_dump_group_by = 2#B;
+pk_dump_ruler = 0;
+pk_dump_ascii = 1;
+
+/* { dg-command { dump :from 0#B :group_by 2#B } } */
+/* { dg-output "00000000: 3031 3233 3435 3637 3839 4142 4344 4546
0123456789ABCDEF\n00000010: 4748 GH"} */
Please split the dg-output into two to avoid that large line:
/* { dg-output "00000000: 3031 3233 3435 3637 3839 4142 4344 4546
0123456789ABCDEF" } */
/* { dg-output "\n00000010: 4748 GH" } */
Likewise for the other test.
Thanks!