[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Allow arrays of size zero
|
From: |
Jose E. Marchesi |
|
Subject: |
Re: [PATCH] Allow arrays of size zero |
|
Date: |
Sun, 17 Nov 2019 14:32:09 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hi John.
Just a couple of notes about the tests.
diff --git a/testsuite/poke.pkl/array-type-diag-2.pk
b/testsuite/poke.pkl/array-type-diag-2.pk
index 4be1d21..8bae56a 100644
--- a/testsuite/poke.pkl/array-type-diag-2.pk
+++ b/testsuite/poke.pkl/array-type-diag-2.pk
@@ -1,3 +1,5 @@
/* { dg-do compile } */
-deftype foo = int[0]; /* { dg-error "" } */
+deftype foo = int[0];
+
+/* { dg-output "" } */
That test should be renamed from array-type-diag-2.pk to
array-type-1.pk, since it is no longer a diagnostics test.
Also, the dg-output tag is not used in 'compile' tests, only in { dg-do
run } tests.
I would also add a test in poke.map, like:
/* { dg-do run } */
/* { dg-data {c*} {0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0 0xb0
0xc0} } */
/* { dg-command { int[0] @ 0#B } } */
/* { dg-output "\\\[\\\]" } */