phpgroupware-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Phpgroupware-tracker] [patch #5374] Add SSO to phpgroupware


From: Dave Hall
Subject: [Phpgroupware-tracker] [patch #5374] Add SSO to phpgroupware
Date: Sun, 17 Sep 2006 11:20:32 +1000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1b2) Gecko/20060601 BonEcho/2.0b2 (Ubuntu-edgy)

Update of patch #5374 (project phpgroupware):

             Assigned to:                    None => Caeies                 

    _______________________________________________________

Follow-up Comment #1:

Hi guys,

I have looked over this, and in general I support it.

Here are my initial comments:

* why is chdir used before include_once ?  Just use include_once with the
right path

* I would like to see the prefs code be OOP'd and using XSLT, as it isn't in
the API this can be done later.

* The phpdocs could do with a bit more work, especially the method arguments
:)

* The link on the login screen, can that be a template block, so it is only
shown when SSO is enabled ?

* the css class "button_group" is for groups of buttons, not links.

* All new templates in HEAD should use CSS not hard coded html attributes
such as bgcolor and other ugly things

I know it has taken me a while to get back to you about this, but things have
been a little crazy.

I am willing to hold the tech preview release while you make the above
changes, if you want this code included in 0.9.18

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?5374>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]