[Phpgroupware-tracker] [bug #13203] offset calculation for timezones incorrect in class.boicalendar.inc.php

[Jan Vilhuber]

URL:
  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=13203>

                 Summary: offset calculation for timezones incorrect in
class.boicalendar.inc.php
                 Project: phpGroupWare
            Submitted by: jvilhuber
            Submitted on: Thu 05/26/2005 at 22:00
              Item Group: 0.9.16.005
                Category: calendar
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
       Component Version: BZIP2
        Platform Version: GNU/Linux - SuSE
         Reproducibility: Every Time
         Planned Release: None
           Fixed Release: 

    _______________________________________________________

Details:

In line 3288 we have the following:

   // use system's date info for caluculating local timezone's offset in
minutes
   //
  $gmt_offset = date('O',$GLOBALS['phpgw']->datetime->users_localtime);  //
offset to GMT
 $offset = intval(substr($gmt_offset, 1, 2)) * 60 +
intval(substr($gmt_offset, 3, 2));
 if ($offset > 0)
  {
        $event['start']['min']   -= $offset;
        $event['end']['min']     -= $offset;
        $event['modtime']['min'] -= $offset;
  }

  
In the 3 lines inside the if-statement, all the '-=' should be '+=', at least
in my situation (US/Pacific time).

I've fixed this in my file to be += in all cases, and now the calculation is
correct, i.e. an entry for 12pm is adjusted to 7pm GMT (and readjusted in
iCal on Mac OS X to 12pm when displaying).








    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=13203>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/