[Phpgroupware-tracker] [patch #3399] bugs corrections for vfs_dav : Improved ls function as well as file_type : performance improvement as well as behavior

[Caeies]

This mail is an automated notification from the patch tracker
 of the project: phpGroupWare.

/**************************************************************************/
[patch #3399] Latest Modifications:

Changes by: 
                Caeies <address@hidden>
'Date: 
                jeu 28.10.2004 at 13:03 (GMT)

------------------ Additional Follow-up Comments ----------------------------
Be carefull, this ls (Perhaps the problem was present in previous dav ls, I 
don't know), the branch 3 of ls don't return the same thing that the branch 3 
sql ls ...
In fact we only get one level of directory, not the whole tree as in sql ls 
with checksubdirs...

I'm in the process of reworking the entire dav layer to solve this problem in a 
"good" way ie like sql, so stay tuned...

Caeies.







/**************************************************************************/
[patch #3399] Full Item Snapshot:

URL: <http://savannah.gnu.org/patch/?func=detailitem&item_id=3399>
Project: phpGroupWare
Submitted by: Caeies
On: mer 29.09.2004 at 07:58

Category:  API -  phpGWapi
Priority:  5 - Normal
Resolution:  None
Privacy:  Public
Assigned to:  None
Originator Email:  
Status:  Open


Summary:  bugs corrections for vfs_dav : Improved ls function as well as 
file_type : performance improvement as well as behavior

Original Submission:  Problems :
 * In file manager, when you try to go in / there was in our case some strange 
behavior of filemanager. In fact, ls was not unseting the right directory in /
 * Instead of using a scope of 1 when doing a ls -ld we use a scoping of 0 to 
get only the properties of the directory/file we have, and not all the files/or 
directories in the listed directory. It seems that it was duplicated code from 
the 3td branche ...

Solution :
 * Use a scope of 0 in case of branch 1 in ls (to return only infos about the 
asked file/directory)
 * Use a scope of 0 for file_type (we only want to know information about this 
file )
 * Modify path_parts, so any trailing / in the real_full_path will be removed 
to avoid problems. THIS PART IS NOT WELL TESTED AGAINST ALL TYPE OF 
CONFIGURATION !.

So this patch is less important than the 2 previous ones and depends on them.

Hope this help somebody, and thanks to oberger ;)

Regards,
Caeies

Follow-up Comments
------------------


-------------------------------------------------------
Date: jeu 28.10.2004 at 13:03       By: Caeies <Caeies>
Be carefull, this ls (Perhaps the problem was present in previous dav ls, I 
don't know), the branch 3 of ls don't return the same thing that the branch 3 
sql ls ...
In fact we only get one level of directory, not the whole tree as in sql ls 
with checksubdirs...

I'm in the process of reworking the entire dav layer to solve this problem in a 
"good" way ie like sql, so stay tuned...

Caeies.





CC List
-------

CC Address                          | Comment
------------------------------------+-----------------------------
oberger                             | FYI



File Attachments
-------------------

-------------------------------------------------------
Date: mer 29.09.2004 at 07:58  Name: bugs_vfs_dav_ls_etc.diff  Size: 2,27KB   
By: Caeies
patch for these problems in vfs_dav
http://savannah.gnu.org/patch/download.php?item_id=3399&amp;item_file_id=3714






For detailed info, follow this link:
<http://savannah.gnu.org/patch/?func=detailitem&item_id=3399>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/