[Phpgroupware-tracker] [bugs #6163] class.schema_proc.inc.php fais for default value

[Andreas Schiller]

This mail is an automated notification from the bugs tracker
 of the project: phpGroupWare.

/**************************************************************************/
[bugs #6163] Latest Modifications:

Changes by: 
                Andreas Schiller <address@hidden>
'Date: 
                Tue 07/13/2004 at 14:52 (Europe/Berlin)

------------------ Additional Follow-up Comments ----------------------------
On line 433:
elseif(!is_numeric($sDefault) && $sDefault != '')
      ^^^

will do.






/**************************************************************************/
[bugs #6163] Full Item Snapshot:

URL: <http://savannah.gnu.org/bugs/?func=detailitem&item_id=6163>
Project: phpGroupWare
Submitted by: Sigurd Nes
On: Sat 10/25/2003 at 17:08

Category:  API - phpGWapi
Item Group:  0.9.16.001
Severity:  7 - Major
Priority:  5 - Normal
Resolution:  Works for me
Assigned to:  skwashd
Status:  Open
Component Version:  CVS
Platform Version:  None
Reproducibility:  None


Summary:  class.schema_proc.inc.php  fais for default value

Original Submission:  when inserting av default text-value 'A' - it tries to 
insert this as an integer.
line 389.
example:
DEFAULT A should read DEFAULT 'A'

Follow-up Comments
------------------


-------------------------------------------------------
Date: Tue 07/13/2004 at 14:52       By: aschiller
On line 433:
elseif(!is_numeric($sDefault) && $sDefault != '')
      ^^^

will do.

-------------------------------------------------------
Date: Sun 07/11/2004 at 10:22       By: skwashd
I tested the attached fix, seems ok to me.  Anyone want to check it?

btw is_numeric("+1 (000) 000-0000") === false

Format: RCS diff from cvs address@hidden UTC

-------------------------------------------------------
Date: Wed 07/07/2004 at 21:19       By: cw
From: Yoshihiro Kamimura <address@hidden>
I was tried to get cvs from .16-branch.
so, re-setup and re-create tables.

but, some error has...
(for Debug mode)
------------------------------------------------ here
Invalid SQL: CREATE TABLE phpgw_addressbook (id ...
MySQL Error: 1064 (Something is wrong in your syntax : '(000) 000-0000, 
tel_home varchar(40) NOT NULL DEFAULT +1 (000) 000-0000 ....
------------------------------------------------ here

DEFAULT statement (for tel-format string) is invalid to say.

ouch, intval("+1 (000) 000-0000") == true... gonna have to think about this one

-------------------------------------------------------
Date: Tue 07/06/2004 at 20:26       By: cw
hm, latest cvs .16 has the 2x' bug now too.

Zone:  what database are you using?  far as I can tell each class properly adds 
the ' itself.

I've fixed .16 and HEAD.  Verified that each db class add the ' and the main 
class doesn't.


-------------------------------------------------------
Date: Tue 07/06/2004 at 19:49       By: cw
bug not present in .16, or if it is it's in one of the db specific files.

it's adding 2 ' in HEAD now.


-------------------------------------------------------
Date: Sun 07/04/2004 at 02:58       By: skwashd
The fix is wrong ... will fix it and retest

-------------------------------------------------------
Date: Wed 06/30/2004 at 06:25       By: skwashd
Fixed in 16 branch, will merge to head shortly

-------------------------------------------------------
Date: Thu 01/15/2004 at 17:41       By: Zone
The attached patch fixes this.  Tested with MySQL and Postgres.  Raising the 
severity of this bug, as it makes HEAD uninstallable when using MySQL.






File Attachments
-------------------

-------------------------------------------------------
Date: Mon 07/12/2004 at 08:03  Name: schema_proc.diff  Size: 364B   By: skwashd
the patch i should have attached
http://savannah.gnu.org/bugs/download.php?item_id=6163&amp;item_file_id=1482

-------------------------------------------------------
Date: Thu 01/15/2004 at 17:41  Name: schema_proc_default_quotes.patch  Size: 
3.83KB   By: Zone
Patch against HEAD on Thu Jan 15 17:35:25 UTC 2004
http://savannah.gnu.org/bugs/download.php?item_id=6163&amp;item_file_id=967






For detailed info, follow this link:
<http://savannah.gnu.org/bugs/?func=detailitem&item_id=6163>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/