[Phpgroupware-tracker] [bugs #6318] Problem updating a table with no data cols in class.so_sql.inc.php

[Dave Hall]

This mail is an automated notification from the bugs tracker
 of the project: phpGroupWare.

/**************************************************************************/
[bugs #6318] Latest Modifications:

Changes by: 
                Dave Hall <address@hidden>
'Date: 
                Sun 06/06/2004 at 23:26 (Australia/Melbourne)

            What     | Removed                   | Added
---------------------------------------------------------------------------
         Assigned to | None                      | Caeies







/**************************************************************************/
[bugs #6318] Full Item Snapshot:

URL: <http://savannah.gnu.org/bugs/?func=detailitem&item_id=6318>
Project: phpGroupWare
Submitted by: Caeies
On: Mon 11/03/2003 at 13:02

Category:  eTemplates
Item Group:  0.9.16RC1
Severity:  5 - Average
Priority:  5 - Normal
Resolution:  None
Assigned to:  Caeies
Status:  Open
Component Version:  CVS
Platform Version:  GNU/Linux - Debian
Reproducibility:  Every Time


Summary:  Problem updating a table with no data cols in class.so_sql.inc.php

Original Submission:  Description :
When trying to update a record in a table that have no data cols (only key 
cols), the update failed.

Solution :
in the file etemplates/inc/class.so_sql.inc.php at line 332
just add a test against the $vals value:

if (!empty($vals))
{
   $this->db->query($sql = "UPDATE $this->table_name SET $vals WHERE 
$keys",__LINE__,__FILE__);
}
else
{
 /* No need to update :)*/
}

Seems working here, but I'm not sure that's there is no correlated bug.
Need to be tested against already made etemplate apps.












For detailed info, follow this link:
<http://savannah.gnu.org/bugs/?func=detailitem&item_id=6318>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/