[Phpgroupware-tracker] [bugs #8975] bug in building sql-query (Better one whitespace too much than too few...)

[Dave Hall]

This mail is an automated notification from the bugs tracker
 of the project: phpGroupWare.

/**************************************************************************/
[bugs #8975] Latest Modifications:

Changes by: 
                Dave Hall <address@hidden>
'Date: 
                Sun 05/16/04 at 11:07 (Australia/Melbourne)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Fixed
         Assigned to | alexbsa                   | skwashd
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
Fixed in 16 cvs.  The patch in its provided form was not usable.






/**************************************************************************/
[bugs #8975] Full Item Snapshot:

URL: <http://savannah.gnu.org/bugs/?func=detailitem&item_id=8975>
Project: phpGroupWare
Submitted by: Matthias Leonhardt
On: Sun 05/16/04 at 09:14

Category:  calendar
Item Group:  0.9.16.000 release
Severity:  5 - Average
Priority:  5 - Normal
Resolution:  Fixed
Assigned to:  skwashd
Status:  Closed
Component Version:  CVS
Platform Version:  GNU/Linux - Debian
Reproducibility:  None


Summary:  bug in building sql-query (Better one whitespace too much than too 
few...)

Original Submission:  Index: class.socalendar_sql.inc.php
===================================================================
RCS file: /cvsroot/phpgroupware/calendar/inc/class.socalendar_sql.inc.php,v
retrieving revision 1.28.2.4.2.8
diff -u -r1.28.2.4.2.8 class.socalendar_sql.inc.php
--- class.socalendar_sql.inc.php        12 Sep 2003 02:16:22 -0000
1.28.2.4.2.8
+++ class.socalendar_sql.inc.php        14 May 2004 15:14:56 -0000
@@ -827,7 +826,7 @@
                $lastmod = intval($lastmod);
                $repeats = (bool) $repeats;
 
-               $user_where = " AND phpgw_cal_user.cal_login = $this->user";
+               $user_where = " AND phpgw_cal_user.cal_login = $this->user ";
 
                $member_groups =
$GLOBALS['phpgw']->accounts->membership($this->user);
                @reset($member_groups);
@@ -846,9 +845,9 @@
 
                if($lastmod > 0)
                {
-                       $wheremod = "AND mdatetime = $lastmod"; 
+                       $wheremod = " AND mdatetime > $lastmod";
                }
-               
+
                $order_by = ' ORDER BY phpgw_cal.cal_id ASC';
                if($this->debug)
                {


Follow-up Comments
------------------


-------------------------------------------------------
Date: Sun 05/16/04 at 11:07         By: skwashd
Fixed in 16 cvs.  The patch in its provided form was not usable.












For detailed info, follow this link:
<http://savannah.gnu.org/bugs/?func=detailitem&item_id=8975>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/