[Phpgroupware-tracker] [bugs #3373] Bad relations between phpgw_log and phpgw_accounts

[Dr. Christian Böttger]

This mail is an automated notification from the bugs tracker
 of the project: phpGroupWare.

/**************************************************************************/
[bugs #3373] Latest Modifications:

Changes by: 
                Dr. Christian Böttger <address@hidden>
'Date: 
                Wed 04/21/04 at 07:41 (Europe/Berlin)

            What     | Removed                   | Added
---------------------------------------------------------------------------
         Assigned to | None                      | skwashd


------------------ Additional Follow-up Comments ----------------------------
Kai, make a suggestion how to improve it ...






/**************************************************************************/
[bugs #3373] Full Item Snapshot:

URL: <http://savannah.gnu.org/bugs/?func=detailitem&item_id=3373>
Project: phpGroupWare
Submitted by: Kai Hofmann
On: Tue 04/29/03 at 09:04

Category:  API - Admin
Item Group:  devel cvs
Severity:  5 - Average
Priority:  5 - Normal
Resolution:  None
Assigned to:  skwashd
Status:  Open
Component Version:  CVS
Platform Version:  None
Reproducibility:  Every Time


Summary:  Bad relations between phpgw_log and phpgw_accounts

Original Submission:  Within the admin module there are two different relations 
between phpgw_log and phpgw_accounts.
An if statement decides between the two variants.
This is absolutly evil! - only one column should be used for relations between 
tables!

                                $parms['where'] = array('phpgw_log.log_user = 
phpgw_accounts.account_id');
                                $parms['where'][] = 'phpgw_log.log_id = 
phpgw_accounts.account_id';
./admin/inc/class.solog.inc.php


Follow-up Comments
------------------


-------------------------------------------------------
Date: Wed 04/21/04 at 07:41         By: cboettger
Kai, make a suggestion how to improve it ...












For detailed info, follow this link:
<http://savannah.gnu.org/bugs/?func=detailitem&item_id=3373>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/