[Phpgroupware-tracker] [support #100802] NIS auth and autoaccounts fail (patch)

[Dr. Christian Böttger]

This mail is an automated notification from the support tracker
 of the project: phpGroupWare.

/**************************************************************************/
[support #100802] Latest Modifications:

Changes by: 
                Dr. Christian Böttger <address@hidden>
'Date: 
                Fri 03/26/04 at 21:30 (Europe/Berlin)

            What     | Removed                   | Added
---------------------------------------------------------------------------
         Assigned to | None                      | skwashd







/**************************************************************************/
[support #100802] Full Item Snapshot:

URL: <http://savannah.gnu.org/support/?func=detailitem&item_id=100802>
Project: phpGroupWare
Submitted by: Nils Rennebarth
On: Wed 04/24/02 at 13:48

Category:  Feature Request
Priority:  5 - Normal
Severity:  3 - Ordinary
Resolution:  None
Assigned to:  skwashd
Originator Email:  
Status:  Open


Summary:  NIS auth and autoaccounts fail (patch)

Original Submission:  
When using "Auto create account records for authenticated
users"=Yes, a user that successfully authenticated
will get an error message and a halted session.

The reason is that

$GLOBALS['phpgw']->accounts->get_type($this->account_lid)

in line 325 of phpgwapi/inc/class.sessions_db.inc.php
is called before checking if account_lid exists and
accounts->get_type isn't ready for nonexistant accounts.

Either repair get_type to return "" if the account is
inexistant or check for existence first.

The following patch implements the first strategy:

--- phpgwapi/inc/class.accounts_sql.inc.php.orig      
 Tue Apr 23 17:38:54 2002
+++ phpgwapi/inc/class.accounts_sql.inc.php     Wed Apr
24 14:48:14 2002
@@ -226,4 +226,8 @@
 
                        $account_id =
get_account_id($accountid);
+                       if($account_id == "")
+                       {
+                               return "";
+                       }
                       
if(@isset($account_type[$account_id]) &&
@$account_type[$account_id])
                        {

Follow-up Comments
------------------


-------------------------------------------------------
Date: Mon 12/09/02 at 00:19         By: skwashd

This is not really a feature request, but the bugs category
has been removed so it can stay in the cat :)












For detailed info, follow this link:
<http://savannah.gnu.org/support/?func=detailitem&item_id=100802>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/