[Phpgroupware-tracker] [bug #5797] Invalid SQL statement on admin/inc/class.soaccess_history.inc.php

[nobody]

=================== BUG #5797: LATEST MODIFICATIONS ==================
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=5797&group_id=509

Changes by: Dave Hall <address@hidden>
Date: Wed 10/08/03 at 17:09 (Australia/Melbourne)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Fixed
         Assigned to | None                      | skwashd
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
Thanks for the bug report.  I did see the diff until after doing the commit.  I 
fixed a couple of other things there.



Please run a cvs update using:

cd /path/phpgroupware/admin/inc

cvs update -dPC



The C flag grabs clean copies so you don't get conflicts.



Cheers



=================== BUG #5797: FULL BUG SNAPSHOT ===================


Submitted by: None                    Project: phpGroupWare                 
Submitted on: Wed 10/08/03 at 12:23
Category:  API - phpGWapi             Bug Group:  0.9.16RC1                 
Severity:  5 - Major                  Priority:  Normal                     
Resolution:  Fixed                    Assigned to:  skwashd                 
Status:  Closed                       Component Version:  CVS               
Platform Version:  None               Reproducibility:  Every Time          

Summary:  Invalid SQL statement on admin/inc/class.soaccess_history.inc.php

Original Submission:  i get error when accessing user login history via 
admin->user accounts->account view->login history, like this:

Database error: Invalid SQL: SELECT COUNT(*) FROM phpgw_access_log AND 
account_id=8



further exploration reveal that such statement contained in 
admin/inc/class.soaccess_history.inc.php function return_logged_out(), that is 
incorrect. there should be WHERE clause instead of AND. diffs attached.



address@hidden a.k.a missGombal



Follow-up Comments
*******************

-------------------------------------------------------
Date: Wed 10/08/03 at 17:09         By: skwashd
Thanks for the bug report.  I did see the diff until after doing the commit.  I 
fixed a couple of other things there.



Please run a cvs update using:

cd /path/phpgroupware/admin/inc

cvs update -dPC



The C flag grabs clean copies so you don't get conflicts.



Cheers


CC list is empty


File Attachments
****************

-------------------------------------------------------
Date: Wed 10/08/03 at 12:23  Name: class.soaccess_history.inc.php.diff  Size: 
0KB   By: None
fix for admin/inc/class.soaccess_history.inc.php
http://savannah.gnu.org/bugs/download.php?group_id=509&amp;bug_id=5797&amp;bug_file_id=708


For detailed info, follow this link:
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=5797&group_id=509

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/