[Phpgroupware-tracker] [bug #5520] database error when editing user and adding applications

[nobody]

=================== BUG #5520: LATEST MODIFICATIONS ==================
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=5520&group_id=509

Changes by: Jonathan Rivera <address@hidden>
Date: Sat 10/04/2003 at 11:50 (GMT)

            What     | Removed                   | Added
---------------------------------------------------------------------------
              Status | Open                      | Closed




=================== BUG #5520: FULL BUG SNAPSHOT ===================


Submitted by: esvinge                 Project: phpGroupWare                 
Submitted on: Tue 09/23/2003 at 21:12
Category:  API - Admin                Bug Group:  0.9.16RC1                 
Severity:  5 - Major                  Priority:  Normal                     
Resolution:  Fixed                    Assigned to:  jarg                    
Status:  Closed                       Component Version:  TGZ               
Platform Version:  Linux - Debian     Reproducibility:  Every Time          

Summary:  database error when editing user and adding applications

Original Submission:  The program tries to add the user to the address book 
even though their is no option to check or not check that and it crashes 
because it has no last name or first name. When all I was trying to do was add 
check marks and increase the number of applications. Not a severe bug but one 
that should be fixed by not adding people to address books by default, and also 
not giving a database crash when people forget to add the first + last names.



Below is the error.



type1person_idvorDatabase error: Invalid SQL: INSERT INTO phpgw_contact_person 
(prefix, first_name, last_name, created_on, created_by, modified_on, 
modified_by, person_id) VALUES ('esvinge', NULL , NULL , '1', '1', '1', '1', 
'3')

MySQL Error: 1048 (Column 'first_name' cannot be null)



File: /home/circlea/www/phpgwapi/inc/class.sql_entity.inc.php

Line: 420

Session halted. 



Follow-up Comments
*******************

-------------------------------------------------------
Date: Fri 10/03/2003 at 04:11       By: jarg
This has been corrected in CVS.



To grab a complete update of all fixes:



1)  Check to see if you have cvs installed: 'cvs --help'.

1a) If not, install a copy of cvs-cli from your favorite 

distro.



2)  Then just type:

    'cd <your phpgroupware dir>; cvs update -dP'.



You can do step 2 as many times in a day as you wish, and 

will always get the most current bug fixes.



Thanks,



-------------------------------------------------------
Date: Wed 09/24/2003 at 04:11       By: esvinge
I found that this error still happens even if an first and last name are 
entered into the fields It still registers the last name as NULL. The account 
which is having these problems is also the default created admin account and it 
has a last and first name entered into it during the edit users listing but 
when I click to edit the user it shows blanks for first and last name. So there 
is a problem with the variables being passed or read, which means that accounts 
can't be edited.

-------------------------------------------------------
Date: Tue 09/23/2003 at 21:46       By: eald
Ok, this bug is reported and will be fixed, but the decission about this was 
that for all accounts must be a contact entry. This is because contact have 
richest information about everyone, and there is an API to know if any given 
contact is a system contact or not.



What I think is that in the upgrade script _must_ create de contacts entries 
for actual users, and for create a new one must just insert an empty string for 
the problematic fields in phpgw_contact_person.



Any comment on this?



Thanks for testing.


CC list is empty


No files currently attached


For detailed info, follow this link:
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=5520&group_id=509

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/