[Phpgroupware-tracker] [bug #5468] phpGroupware depends on error reporting = E_ALL ~E_NOTICE

[nobody]

=================== BUG #5468: LATEST MODIFICATIONS ==================
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=5468&group_id=509

Changes by: Dave Hall <address@hidden>
Date: Tue 09/23/03 at 06:31 (Australia/Melbourne)

            What     | Removed                   | Added
---------------------------------------------------------------------------
            Severity | 5 - Major                 | 1 - Ordinary
            Priority | High                      | Normal
          Resolution | None                      | Fixed
         Assigned to | None                      | skwashd
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
Thanks for the bug report.



We discussed making phpGW run with E_ALL error reporting in 16, but it was 
found that just to get the API to run with that level of error reporting would 
be a lot of work for very little gain.



phpGW is not designed to be run with E_NOTICES error reporting on, this is 
almost impossible to acheive without adding @ error supressors in front of 
every array.  I have run it with E_ALL from time to time to find silly bugs 
like the one you found in class.setup.inc.php, but it is not possible to run it 
like this all the time.



The php manual points out that E_NOTICES is not enabled by default ... 
http://au2.php.net/manual/en/phpdevel-errors.php#internal.e-notice



Thanks for the bug report.  I am going to close this one, as the 
class.setup.inc.php bug is now fixed.  If you find others, please post them 
here are they will be dealt with.



Cheers 



=================== BUG #5468: FULL BUG SNAPSHOT ===================


Submitted by: meebey                  Project: phpGroupWare                 
Submitted on: Mon 09/22/03 at 18:57
Category:  None                       Bug Group:  0.9.16RC1                 
Severity:  1 - Ordinary               Priority:  Normal                     
Resolution:  Fixed                    Assigned to:  skwashd                 
Status:  Closed                       Component Version:  None              
Platform Version:  Linux - Debian     Reproducibility:  Every Time          

Summary:  phpGroupware depends on error reporting = E_ALL ~E_NOTICE

Original Submission:  I get alots of notices about undefined variables, those 
are that much that I believe phpGroupware was never tested with proper error 
reporting level...



For example the setup page, there I get:



Notice: Undefined index: FormDomain in 
/www/groupware-test.gsd-software.net/htdocs/phpgwapi/inc/class.setup.inc.php on 
line 56



Notice: Undefined property: Link_ID in 
/www/groupware-test.gsd-software.net/htdocs/phpgwapi/inc/class.db_mysql.inc.php 
on line 454



Notice: Undefined property: Link_ID in 
/www/groupware-test.gsd-software.net/htdocs/phpgwapi/inc/class.db_mysql.inc.php 
on line 51



Notice: Undefined property: Query_ID in 
/www/groupware-test.gsd-software.net/htdocs/phpgwapi/inc/class.db_mysql.inc.php 
on line 130



Sometimes those notices are harmless, but often they show problems in the code 
flow.. I found one in "phpgwapi/inc/class.setup.inc.php"

on line 809 (that if() in the get_hooks_table_name() function)

it tries to use $setup_info[] but there is no global for that array neither its 
a parameter...



please fix those unnice code things.. just use error_reporting(E_ALL); and you 
will find all problems.





Follow-up Comments
*******************

-------------------------------------------------------
Date: Tue 09/23/03 at 06:31         By: skwashd
Thanks for the bug report.



We discussed making phpGW run with E_ALL error reporting in 16, but it was 
found that just to get the API to run with that level of error reporting would 
be a lot of work for very little gain.



phpGW is not designed to be run with E_NOTICES error reporting on, this is 
almost impossible to acheive without adding @ error supressors in front of 
every array.  I have run it with E_ALL from time to time to find silly bugs 
like the one you found in class.setup.inc.php, but it is not possible to run it 
like this all the time.



The php manual points out that E_NOTICES is not enabled by default ... 
http://au2.php.net/manual/en/phpdevel-errors.php#internal.e-notice



Thanks for the bug report.  I am going to close this one, as the 
class.setup.inc.php bug is now fixed.  If you find others, please post them 
here are they will be dealt with.



Cheers 


CC list is empty


No files currently attached


For detailed info, follow this link:
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=5468&group_id=509

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/