[Phpgroupware-tracker] [Patch #245] xml.so and PHP3

[nobody]

Patch #245 has been updated. 

Project: 
Category: None
Status: Closed
Summary: xml.so and PHP3

Follow-Ups:

Date: Wed 04/17/2002 at 12:26
By: Zone

Comment:
Not an elegant patch, but AFAICT there is no way of detecting whether an dl() 
call will succeed, or doing error trapping on it.  Default PHP3 installs (from 
source) don't include the XML extension, so PHP3 installers will find they 
can't load the main page without editing the source code.

With this patch, PHP3 users will have to explicitly edit the source code to use 
the functions in xml_functions.inc.php, which I think is a more practical 
solution, but you may have other opinions.
-------------------------------------------------------

Date: Wed 04/24/2002 at 23:00
By: milosch

Comment:
I am finding that trapping dl() failure is impossible.  However, I am working 
on a small class to handle this type
of check in a generic way.  It includes a small array of extensions and 
possible module names.  If only dl() could
be trapped, this would be ideal.  Check out class.phpext.inc.php and see what 
you think...

-------------------------------------------------------

Date: Thu 04/25/2002 at 15:23
By: Zone

Comment:
The class looks good.  Two things:

1) It will still bail in PHP3, so a decision may have to made at some point 
(support PHP3 by default or support PHP's XML extension by default).

2) The error_reporting() value should be trapped before error_reporting(0); and 
set back to what it was before (instead of explicitly setting E_ERROR | 
E_WARNING | E_PARSE).
-------------------------------------------------------

Date: Thu 04/25/2002 at 18:44
By: milosch

Comment:
Aha, but we already set error_reporting to this anyway in functions or 
common_functions.

Yes, it does bail on php3...
-------------------------------------------------------

Date: Sun 05/04/2003 at 16:36
By: skwashd

Comment:
>From the 0.9.16 release onwards we will drop support for php3 - the 
>requirement will now be PHP 4.1+
-------------------------------------------------------

-------------------------------------------------------
For more info, visit:

http://savannah.gnu.org/patch/?func=detailpatch&patch_id=245&group_id=509