[Phpgroupware-tracker] [Bug #3377] SQL change suggestion for /projects/inc/class.sobilling.inc.php

[nobody]

=================== BUG #3377: LATEST MODIFICATIONS ==================
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=3377&group_id=509

Changes by: Dave Hall <address@hidden>
Date: Wed 04/30/2003 at 10:20 (Australia/Melbourne)

            What     | Removed                   | Added
---------------------------------------------------------------------------
         Assigned to | None                      | ceb
             Summary | SQL select should be changed | SQL change suggestion for 
/projects/inc/class.sobilling.inc.php




=================== BUG #3377: FULL BUG SNAPSHOT ===================


Submitted by: powerstat               Project: phpGroupWare                 
Submitted on: Tue 04/29/2003 at 19:10
Category:  projects                   Bug Group:  None                      
Severity:  5 - Major                  Priority:  Low                        
Resolution:  None                     Assigned to:  ceb                     
Status:  Open                         Component Version:  None              
Platform Version:  None               Reproducibility:  None                

Summary:  SQL change suggestion for /projects/inc/class.sobilling.inc.php

Original Submission:  Withinthe following sql statement 
"phpgw_p_hours.activity_id=phpgw_p_projectactivities.activity_id" should be 
replaced with
"phpgw_p_activities.id=phpgw_p_projectactivities.activity_id":

        $this->db->query("SELECT phpgw_p_hours.id as 
id,phpgw_p_hours.hours_descr,phpgw_p_activities.descr,phpgw_p_hours.status, "
                                                . 
"phpgw_p_hours.start_date,phpgw_p_hours.end_date,phpgw_p_hours.minutes,phpgw_p_hours.minperae,phpgw_p_hours.billperae,"
                                                . "phpgw_p_hours.employee FROM 
phpgw_p_hours " . $this->return_join() . " phpgw_p_activities ON "
                                                . 
"phpgw_p_hours.activity_id=phpgw_p_activities.id " . $this->return_join() . " 
phpgw_p_projectactivities ON "
                                                . 
"phpgw_p_hours.activity_id=phpgw_p_projectactivities.activity_id WHERE 
(phpgw_p_hours.status='done' OR "
                                                . 
"phpgw_p_hours.status='closed') AND (phpgw_p_hours.project_id='" . $project_id 
. "'" . $parent_hours . ") AND "
                                                . 
"phpgw_p_projectactivities.project_id='" . $project_id . "' AND 
phpgw_p_projectactivities.billable='Y' "
                                                . "AND 
phpgw_p_projectactivities.activity_id=phpgw_p_hours.activity_id " . 
$ordermethod,__LINE__,__FILE__);
./projects/inc/class.sobilling.inc.php




No Followups Have Been Posted


CC list is empty


No files currently attached


For detailed info, follow this link:
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=3377&group_id=509