[Phpgroupware-tracker] [ 100802 ] NIS auth and autoaccounts fail (patch)

[nobody]

Support Request #100802, was updated on 2002-Apr-24 23:48
You can respond by visiting: 
http://savannah.gnu.org/support/?func=detailsupport&support_id=100802&group_id=509

Category: Feature Request
Status: Open
Priority: 5
Summary: NIS auth and autoaccounts fail (patch)

By: skwashd
Date: 2002-Dec-09 11:19
Logged In: YES 
user_id=2480
Browser: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.1) Gecko/20020826

This is not really a feature request, but the bugs category
has been removed so it can stay in the cat :)

----------------------------------------------------------------------

By: nilsr
Date: 2002-Apr-24 23:48
Logged In: YES 
user_id=6910
Browser: Mozilla/5.0 Galeon/1.2.1 (X11; Linux i686; U;) Gecko/20020421 
Debian/1.2.1-1

When using "Auto create account records for authenticated
users"=Yes, a user that successfully authenticated
will get an error message and a halted session.

The reason is that

$GLOBALS['phpgw']->accounts->get_type($this->account_lid)

in line 325 of phpgwapi/inc/class.sessions_db.inc.php
is called before checking if account_lid exists and
accounts->get_type isn't ready for nonexistant accounts.

Either repair get_type to return "" if the account is
inexistant or check for existence first.

The following patch implements the first strategy:

--- phpgwapi/inc/class.accounts_sql.inc.php.orig      
 Tue Apr 23 17:38:54 2002
+++ phpgwapi/inc/class.accounts_sql.inc.php     Wed Apr
24 14:48:14 2002
@@ -226,4 +226,8 @@
 
                        $account_id =
get_account_id($accountid);
+                       if($account_id == "")
+                       {
+                               return "";
+                       }
                       
if(@isset($account_type[$account_id]) &&
@$account_type[$account_id])
                        {


----------------------------------------------------------------------
You can respond by visiting: 
http://savannah.gnu.org/support/?func=detailsupport&support_id=100802&group_id=509