[Phpgroupware-tracker] [Bug #1753] Event times in icalendar notifications are not local TZ

[nobody]

=================== BUG #1753: LATEST MODIFICATIONS ==================
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=1753&group_id=509

Changes by: Dave Hall <address@hidden>
Date: 2002-Nov-23 20:01 (Australia/Melbourne)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Invalid
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
I have added a note to the patch.  

Unfortunately we can not support untested patches.  All patches stay in the 
patch manager until properly tested.  The are then either added to cvs or 
deleted.  We only support the official distribution and our cvs code.

Sorry you had a bad experience with a patch, and thanks for the feedback.  In 
future please use the cvs codebase, that is supported.

Cheers



=================== BUG #1753: FULL BUG SNAPSHOT ===================


Submitted by: tbecker37                 Project: phpGroupWare                   
Submitted on: 2002-Nov-20 09:36
Category:  calendar                     Bug Group:  0.9.14 release              
Severity:  5 - Major                    Priority:  Normal                       
Resolution:  Invalid                    Assigned to:  None                      
Status:  Closed                         Component Version:  CVS                 
Platform Version:  Linux - RedHat       Reproducibility:  Every Time            

Summary:  Event times in icalendar notifications are not local TZ

Original Submission:  After applying patch 567 (add icalendar notifications) to 
the current stable CVS, the event times in icalendar e-mail notifications are 
off by -2x the system TZ offset.  An event scheduled for 7pm MST (-7 GMT 
offset) will be scheduled at 5am in the icalendar notification.  

I believe the problem is a switched sign (- for +) in the patch.  Lines 225-227 
in patch 567 are:

+            $event['start']['min']   -= $offset;
+            $event['end']['min']     -= $offset;
+            $event['modtime']['min'] -= $offset;

Changing these lines to:

+            $event['start']['min']   += $offset;
+            $event['end']['min']     += $offset;
+            $event['modtime']['min'] += $offset;

seems to fix the problem.  

Follow-up Comments
*******************

-------------------------------------------------------
Date: 2002-Nov-23 20:01             By: skwashd
I have added a note to the patch.  

Unfortunately we can not support untested patches.  All patches stay in the 
patch manager until properly tested.  The are then either added to cvs or 
deleted.  We only support the official distribution and our cvs code.

Sorry you had a bad experience with a patch, and thanks for the feedback.  In 
future please use the cvs codebase, that is supported.

Cheers


CC list is empty


No files currently attached


For detailed info, follow this link:
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=1753&group_id=509