phpgroupware-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Phpgroupware-tracker] [Patch #209] Sybase port


From: nobody
Subject: [Phpgroupware-tracker] [Patch #209] Sybase port
Date: Fri, 22 Nov 2002 21:45:13 -0500

Patch #209 has been updated. 

Project: 
Category: API -  phpGWapi
Status: Open
Summary: Sybase port

Follow-Ups:

Date: 2002-Apr-03 19:36
By: ymettier

Comment:
Some comments about my patch:
- Apply it on 0.9.14rc2

- class.schema_proc.inc.php: sybase columns are "NOT NULL" by default. That's 
why I needed to add the keyword "NULL" if it is not "NOT NULL". It works for 
sybase, and phpgroupware will not work without it with sybase. I have not 
tested it with any other database engine (pgsql and mysql).

- *sybase*.php: this is my main contribution. It is still experimental and 
should work in some cases and not in others. But without it, 0.9.14rc2 will not 
work at all with sybase. About the quality of my contribution, I tried to do it 
as clean as I could. But due to limitations of Sybase, I had to make things 
that are a little dirty, like analyse requests in order to rewrite them if 
needed. Doing things clean means that all the database requests should be 
rewritten in the whole phpgroupware code. I prefer to submit you something 
small that works and if you think it is necessary, make some bigger changes 
after that.

- manageheader.php: minor change in order to let users choose sybase. I am not 
sure it's a good idea to accept this as is because the sybase port is 
experimental. Maybe you should apply it but comment it?

I'm going on vacation on Apr 9th and I will continue to work on the sybase port 
when I'm back!

Yves
-------------------------------------------------------

Date: 2002-Nov-15 20:57
By: skwashd

Comment:
Hey mdean,

Do you want to look at this one?  I know nothing about Sybase.

Cheers
-------------------------------------------------------

Date: 2002-Nov-15 21:15
By: ymettier

Comment:
Hi

My job changed and I will not be able to maintain the patch any more.
But I would be pleased, if another contributor wants to contribute on sybase, 
if he could start with my work and not from scratch.

Yves
-------------------------------------------------------

Date: 2002-Nov-23 13:45
By: skwashd

Comment:
mdean said this was ok to go into stable

ymettier thats ok ... i will still go in ... and thanks

Cheers
-------------------------------------------------------

-------------------------------------------------------
For more info, visit:

http://savannah.gnu.org/patch/?func=detailpatch&patch_id=209&group_id=509




reply via email to

[Prev in Thread] Current Thread [Next in Thread]