phpgroupware-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Phpgroupware-tracker] [Bug #132] Mcrypt option in header.inc.php


From: noreply
Subject: [Phpgroupware-tracker] [Bug #132] Mcrypt option in header.inc.php
Date: Fri, 26 Apr 2002 19:23:51 -0400

=================== Bug #132: Full Bug Snapshot ===================
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=132&group_id=509

Submitted by: None                      Project: phpGroupWare                   
Submitted on: 2002-Apr-25 21:43
Category:  API - Setup                  Bug Group:  devel cvs                   
Severity:  5 - Major                    Priority:  None                         
Resolution:  None                       Assigned to:  milosch                   
Status:  Open                           Platform Version:  None                 
Reproducibility:  Every Time            

Summary:  Mcrypt option in header.inc.php

Original Submission:  I just did a fresh clean CVS checkout and I have found a 
nasty little bug. 
I turned off Mcrypt in the header.inc.php file, but when I log into the header 
admin page I get my settings with Mcrypt _enabled_. I tried to set it to false, 
but every time I enter the header admin, it's turned on. 
When I try to log into phpGW I also get an error: 
Fatal error: Call to undefined function: mcrypt_module_open() in 
/users/grosvadssk-nu/http/extapps/phpgroupware/phpgwapi/inc/class.crypto.inc.php
 on line 88

so I kind of wonder if Mcrypt really is turned off. 

I hope I'm not being a fool...

Peter Andersson in Sweden

BTW Keep up the good work!

Follow-up Comments
*******************

-------------------------------------------------------
Date: 2002-Apr-26 23:23             By: peter_a
Another hint in trying to find out what is wrong:
In phpgw_app_sessions there is a single post with sessionid 0, loginid 0, 
location config, app phpgwapi, content = a large array with different settings. 
These settings seem to stick around even if you update the header.inc.php file. 
First at login header.inc.php file is loaded, and afterwards in 
functions.inc.php, line 211 the array from db is read, overwriting the settings 
in header.inc.php 
NOT good! Might even be a security issue?
Anyway either this post in db isn't supposed to stick around, or something else 
is wrong. 
If I delete the post, everything works ok, but the new post does stick too. 
This problem probably applies to all the settings doubled in header.inc.php and 
table phpgw_app_sessions.
I have the db tables since older version (.12), is table changed? 
Is it a bug in session managment? I can't get this figured out. HELP!

-------------------------------------------------------
Date: 2002-Apr-26 18:03             By: None
I looked into the file phpgwapi/inc/class.crypto.inc.php and dicovered that 
line 52 checks if mcrypt is enabled, and it says the value is 1 even if it 
obviously is 0 (False) in header.inc.php, strange. 
There must be a line somwere in the code where this setting is hardcoded after 
reading the header.inc.php!
I will try to find it. 

I'm sorry to write so much. I'm not a programmer, but this seems to be doable 
to me, I hope.
Cheers

-------------------------------------------------------
Date: 2002-Apr-26 17:37             By: None
I found the bug in manageheader.tpl on my own. I don't have CVS access, so 
Milosch please edit the file accordingly.

The lines 40/41 should probably look like this:
        <option value="True"{mcrypt_enabled_yes}>True</option>
        <option value="False"{mcrypt_enabled_no}>False</option>

This makes the header admin work, but still I get the 
Fatal error: Call to undefined function: mcrypt_module_open() in 
/users/grosvadssk-nu/http/extapps/phpgroupware/phpgwapi/inc/class.crypto.inc.php
 on line 88
error when trying to login. 
Is $GLOBALS['phpgw_info']['server']['mcrypt_enabled'] the right variable at all?

Peter Andersson

-------------------------------------------------------
Date: 2002-Apr-26 16:35             By: None
Milosch, it got even worse!
The change you did sets the value to either True or nothing, which then becomes 
a parse error. 
Maybe I wasn't clear enough before. Before the fix, I got the settings True and 
False in the header.inc.php file, but when enterring the header admin it always 
states True. 
Now I suspect that you have altered the name of the setting so that neither 
headeradmin nor the phpgwapi recognizes the setting as Mcrypt_enabled = False

Does this make sense? 

-------------------------------------------------------
Date: 2002-Apr-26 10:42             By: milosch
Try an update of setup/templates/default/manageheader.tpl.


-------------------------------------------------------
Date: 2002-Apr-26 06:46             By: None
My CVS full checkout commands
I used these yesterday

cvs -d:pserver:address@hidden:/cvsroot/phpgroupware login
cvs -z3 -d:pserver:address@hidden:/cvsroot/phpgroupware co phpgroupware 
addressbook admin backup bookkeeping bookmarks brewer calendar cart ccs cdb 
chat chora comic cron developer_tools dj eldaptir email filemanager forum ftp 
headlines hr infolog inv manual mediadb meerkat messenger napster netsaint 
news_admin nntp notes phonelog phpGWShell_Win32_VB phpgwapi phpgwnetsaint 
phpsysinfo phpwebhosting polls preferences projects qmailldap rbs setup skel 
soap squirrelmail stocks syncml-server timetrack todo transy tts wap wcm 
weather xmlrpc 


-------------------------------------------------------
Date: 2002-Apr-26 02:34             By: skeeter
Which version of phpGW are you using?

Thanks,
Mark A Peters (Skeeter)


For detailed info, follow this link:
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=132&group_id=509



reply via email to

[Prev in Thread] Current Thread [Next in Thread]