Re: [pdf-devel] [patch] convert LZW filter to new API

[jemarch]

   >    -AM_CFLAGS = -Wall -fno-strict-aliasing $(LIBGCRYPT_CFLAGS)
   >    +AM_CFLAGS = -Wall -fno-strict-aliasing -Wconversion $(LIBGCRYPT_CFLAGS)
   >
   > The -Wconversion option makes gcc to generate a lot of warnings in
   > both header files included from gnulib and our source code.  Is there
   > a particular reason to add that switch?
   That probably shouldn't have been merged. It often shows some useful bugs, 
but 
   also shows some unwarranted warnings.

I consider that option ideal for an activate->compile->look for
something fishy->deactivate process :)

   In the longer term, we should be using some more targeted warning
   flags, and trying to fix the warnings.

Agreed.

---
Jose E. Marchesi
address@hidden

GNU Project
http://www.gnu.org