[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[pdf-devel] pdf_time_span_negate()
From: |
Brad Hards |
Subject: |
[pdf-devel] pdf_time_span_negate() |
Date: |
Sat, 13 Jun 2009 20:34:49 +1000 |
User-agent: |
KMail/1.9.10 |
The pdf_time_span_negate_003 test fails.
It isn't clear to me what the fix is, because the test and associated
documentation don't match very well. I'm assuming it is mean to be a check
that passing a null pointer produces PDF_ERROR.
Here is a patch that does that:
=== modified file 'src/base/pdf-time.c'
--- src/base/pdf-time.c 2008-09-10 13:50:25 +0000
+++ src/base/pdf-time.c 2009-06-13 10:25:01 +0000
@@ -1064,8 +1064,12 @@
pdf_time_span_negate (pdf_time_span_t *p_span)
{
pdf_status_t p_status = PDF_OK;
+ if ( p_span == NULL )
+ {
+ return PDF_ERROR;
+ }
pdf_i64_neg(p_span, *p_span, &p_status);
- return PDF_OK;
+ return p_status;
}
=== modified file 'torture/unit/base/time/pdf-time-span-negate.c'
--- torture/unit/base/time/pdf-time-span-negate.c 2009-05-07 10:31:42
+0000
+++ torture/unit/base/time/pdf-time-span-negate.c 2009-06-13 10:25:52
+0000
@@ -102,15 +102,14 @@
* Try to get invoke pdf_time_span_negate where
* argument pointer is NUL.
*Success condition:
- * 1. Function pdf_time_span_new schould return PDF_OK
- * 2. Function pdf_time_span_negate schould return PDF_ERROR
+ * 1. Function pdf_time_span_negate schould return PDF_ERROR
*/
START_TEST (pdf_time_span_negate_003)
{
pdf_status_t status;
- pdf_time_span_t span;
-
- status = pdf_time_span_negate(&span);
+ pdf_time_span_t *span = 0;
+
+ status = pdf_time_span_negate(span);
fail_if(status != PDF_ERROR);
}
Comments?
Brad
fix-time-span-negate003-2009-06-13.patch
Description: Text Data
- [pdf-devel] pdf_time_span_negate(),
Brad Hards <=