[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [pdf-devel] Text module unit tests failing
From: |
jemarch |
Subject: |
Re: [pdf-devel] Text module unit tests failing |
Date: |
Mon, 15 Sep 2008 23:48:05 +0200 |
User-agent: |
Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (Shijō) APEL/10.6 Emacs/23.0.60 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
Thanks for your explanation!
Thank you for your implementation of the text module :)
> /* Get system default locale name and check it */
> locale_name = gl_locale_name(LC_CTYPE, "LC_CTYPE");
> - if((locale_name == NULL) || \
> - (strlen(locale_name)< 2))
> + if (locale_name == NULL)
> {
> PDF_DEBUG_BASE("Invalid locale info detected! '%s'",
> ((locale_name!=NULL) ? locale_name : "null"));
> return PDF_ETEXTENC;
> }
As you now just check if locale_name is NULL, there is no need to check
it again within the debug message. So the debug message could be just:
PDF_DEBUG_BASE("Invalid locale info detected! (null)");
All the other stuff seems to be ok for me.
Ok. The patch is installed in the trunk now.
Did you check the unit tests with this change?
Yes, I did.
Thanks.
- Re: [pdf-devel] Text module unit tests failing, (continued)
- Re: [pdf-devel] Text module unit tests failing, pete, 2008/09/14
- Re: [pdf-devel] Text module unit tests failing, jemarch, 2008/09/14
- Re: [pdf-devel] Text module unit tests failing, Zac Brown, 2008/09/14
- Re: [pdf-devel] Text module unit tests failing, Karl Berry, 2008/09/14
- Re: [pdf-devel] Text module unit tests failing, Aleksander Morgado, 2008/09/15
- Re: [pdf-devel] Text module unit tests failing, gerel, 2008/09/15
- Re: [pdf-devel] Text module unit tests failing, jemarch, 2008/09/15
- Re: [pdf-devel] Text module unit tests failing, Aleksander Morgado, 2008/09/15
- Re: [pdf-devel] Text module unit tests failing,
jemarch <=