Re: [paragui-users] Re: paragui-users Digest, Vol 7, Issue 15

[Alexander Pipelka]

Am Sam, 2003-06-28 um 18.29 schrieb H. C.:
> Hi,
> 
> even every GetText(), GetTitle() etc. return you a reference to internal
> data structure. You are always free to do dangerous things to pointers :) .
> What about those people who want to modify the icon directly? With the way
> you prefer, they'd have to modify the copy of that icon and use SetIcon(...)
> again to apply the changes. But that would be unnecessary for such people.

I applied your patches (thanks).

Passing pointers is always dangerous. Right :)
I think it's ok here. I prefer to have the freedom to do some things
only people knowing what they do have ;^)

> 
> Concerning your second suggestion: Wouldn't that break binary compatibility?

Not specifically in this case. But changing the API would only make
sense if we also change all other functions. It's definitely something
we should consider for the 1.2 API.

The current API emerged to some kind of wilderness. Cleanups (breaking
binary compatibility) are really neccessary.

Alex

> 
> Kind regards,
>     H. C.
> 
> ----- Original Message ----- 
> From: <address@hidden>
> To: <address@hidden>
> Sent: Saturday, June 28, 2003 6:03 PM
> Subject: paragui-users Digest, Vol 7, Issue 15
> 
> 
> > Send paragui-users mailing list submissions to
> > address@hidden
> >
> > To subscribe or unsubscribe via the World Wide Web, visit
> > http://mail.nongnu.org/mailman/listinfo/paragui-users
> > or, via email, send a message with subject or body 'help' to
> > address@hidden
> >
> > You can reach the person managing the list at
> > address@hidden
> >
> > When replying, please edit your Subject line so it is more specific
> > than "Re: Contents of paragui-users digest..."
> >
> >
> > Today's Topics:
> >
> >    1. Re: patch (Atani)
> >
> >
> > ----------------------------------------------------------------------
> >
> > Date: Sat, 28 Jun 2003 07:40:31 -0700
> > From: Atani <address@hidden>
> > To: address@hidden, "H. C." <address@hidden>
> > Subject: Re: [paragui-users] patch
> > Message-ID: <address@hidden>
> > In-Reply-To: <address@hidden>
> > References: <address@hidden>
> > Content-Type: text/plain;
> >   charset="iso-8859-1"
> > MIME-Version: 1.0
> > Content-Transfer-Encoding: 7bit
> > Precedence: list
> > Reply-To: address@hidden
> > Message: 1
> >
> > On Saturday 28 June 2003 03:49 am, H. C. wrote:
> > > - added GetIcon(Uint8 num) to PG_Button (num has to be either 0, 1 or
> 2 -
> > > it represents the different images for iconup, icondown and iconover) -
> > > added GetIcon() to PG_Label
> >
> > I see one small potential flaw in the patch....  It opens up (via
> pointers)
> > the ability for the internal data structure for the icons to be fully and
> > directly modified.  This should instead return either a copy or a constant
> > version.
> >
> > Additionally, it would be better to use an enum (or constants) defined on
> > PG_Button for the 0,1,2 index values.  This will make the code easier to
> read
> > and understand what it is doing not to mention make the checks a bit
> cleaner
> > in the PG_Button code (ie: have a min and max constant value and do bounds
> > checking)
> >
> > Mike
> >
> >
> >
> > ------------------------------
> >
> > _______________________________________________
> > paragui-users mailing list
> > address@hidden
> > http://mail.nongnu.org/mailman/listinfo/paragui-users
> >
> >
> > End of paragui-users Digest, Vol 7, Issue 15
> > ********************************************
> >
> 
> 
> 
> _______________________________________________
> paragui-users mailing list
> address@hidden
> http://mail.nongnu.org/mailman/listinfo/paragui-users