[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Paparazzi-devel] Digital_cam module / DC_SHOT overflow

From: Christophe De Wagter
Subject: Re: [Paparazzi-devel] Digital_cam module / DC_SHOT overflow
Date: Wed, 24 Apr 2013 09:48:08 +0200

The initial design was to use as little telemetry as possible (uint8_t) but make sure we know which coordinates are missing by having a picture number. An overflow is easy to resolve on the ground so for us 8-bit was fine.

I believe afterwards someone else found that 255 photos is not sufficient (I agree: we usually have 400+ photo/flight) and changed it to a 16-bit counter.

Probably this 1 byte of telemetry will not make a big difference so 16-bit telemetry is fine with me as it makes things nicer for end-users.


On Tue, Apr 23, 2013 at 11:21 PM, Felix Ruess <address@hidden> wrote:

I'm wondering why this limit is in there at all...
Also this should then be adjusted in the DC_INFO message as well, where the dc_buffer is transmitted as int8 instead of uint16.

@Christophe, any comments on that?

Cheers, Felix

On Tue, Apr 23, 2013 at 4:33 PM, Eduardo lavratti <address@hidden> wrote:
You are right
I increased the IMAGE_BUFFER to high value and the problem not occur anymore.

Change the value in yout airframe file:

   <load name="openlog.xml"/>
    <load name="nav_catapult.xml"/>
    <load name="digital_cam.xml">
      <define name="DC_SHUTTER_LED" value="CAM_SWITCH_LED"/> <!--CAM_SWITCH_LED-->
      <define name="DC_PUSH" value="LED_OFF" />
      <define name="DC_RELEASE" value="LED_ON" />
      <define name="DC_IMAGE_BUFFER" value="16535"/>

ate: Tue, 23 Apr 2013 16:13:28 +0200
From: address@hidden
To: address@hidden
Subject: [Paparazzi-devel] Digital_cam module / DC_SHOT overflow

Dear all,

I noticed an issue with the DC_SHOT photo number increment: photo number is okay until 255 photos have been taken, then it sticks to 255 in the DC_SHOT message.
I think we should increase the default value of DC_IMAGE_BUFFER (which is 255) in dc.h (Digital_cam module).

  if (dc_buffer < DC_IMAGE_BUFFER) {
    photo_nr = dc_photo_nr;

Do you agree with that ? 


_______________________________________________ Paparazzi-devel mailing list address@hidden

Paparazzi-devel mailing list

Paparazzi-devel mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]