Re: [Paparazzi-devel] STM-I2C with Aspirin v1.5 Fixed

[Felix Ruess]

Ok, deleted the stm_i2c branch as it's merged into dev_i2c.

I didn't just add the files, as I thought it might be nice to keep the history...

Also lisa_l baro is enabled again, and that was the only thing that was disabled.

As already said, for testing in dev_i2c right now you can select the new driver via

<configure name="USE_NEW_I2C_DRIVER" value="1"/>

But since Piotr already ported your new i2c driver to libopencm3, we could also just test the locm3 branch instead of dev_i2c.

So it has the new driver as default (actually only has the new driver, old one removed), but additionally most things ported from the STM libs to libopencm3.....

To not cause him more pain merging I would say we don't merge dev_i2c, but rather merge locm3 when it's ready?

Which way do you guys prefer? Also if you add additional stuff it will probably be in locm3 anyway?

Cheers, Felix

On Thu, Mar 15, 2012 at 9:22 PM, Piotr Esden-Tempski <address@hidden> wrote:

Hi guys,

How does all this play with the libopencm3 port of the driver? Has any of you looked at the port how should we proceed with the merge there?

I got the first full autopilot compile and work properly in the port yesterday. It is pushed to the locm3 branch. I will try to merge the changes but there may be issues coming from me doing the port based on an older codebase.

Any ideas?

Cheers Piotr

On Mar 15, 2012, at 12:55 PM, Christophe De Wagter wrote:

> Hi Felix,
>
> The old i2c branch can be removed, and keep just the i2c+dev.
>
> It can be merged but I would --stash it and manually just add the new files and revert all test files like baro... There was also the new i2c event function which might move to a more generic watchdog_event :-)
>
> (spi with DMA might also benefit from a watchdog, ... etc)
>
> -Christophe
>
>
>
> On Thu, Mar 15, 2012 at 8:50 PM, Felix Ruess <address@hidden> wrote:
> Very nice!
> Works splendidly so far :-)
>
> Since the stm_i2c branch is basically master + the new driver, I created the dev_i2c branch where it's basically merged into dev...
> So for testing I would recommend the dev_i2c branch, there you can also select the old or new driver from your airframe file.
> To use the new one add the following configure to the ap target in your airframe file:
> <configure name="USE_NEW_I2C_DRIVER" value="1"/>
> If you omit the configure or set it to zero the old one is used (so it's the default).
>
> @Christophe, any reason to not merge this into dev now (with the old one as default like in dev_i2c)?
> The only thing is that you disabled the baro on Lisa/L, was that just for testing? Can we enable that again?
>
> Cheers, Felix
>
>
> On Thu, Mar 15, 2012 at 3:33 PM, Simon Wilks <address@hidden> wrote:
> Excellent!!! One step closer :)
>
> On Thu, Mar 15, 2012 at 11:20 AM, Christophe De Wagter <address@hidden> wrote:
> The issue of "rubbish" gyro data with stm-i2c new driver with aspirin gyro's was found.
>
> The reason is the new driver changes the transaction type from TxRx to Rx after the Tx is finished. As the aspirin driver does not reset the type each time, you end up doing Rx instead of TxRx. This means we are reading all registers in a loop, which obviously gives weird results.
>
> This is a potential hassard for other drivers that would re-use the same transaction several times and use TxRx but do not reset it each time. (HMC works did that well, and was therefor working)
>
> A fix was pushed to paparazzi/stm_i2c : https://github.com/paparazzi/paparazzi/commit/bf2b29a82be3ba7fa642b2fdf7409d878ce3b4d2
>
>
>
>
>
>
> --
> -Christophe
>
>
> _______________________________________________
> Paparazzi-devel mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/paparazzi-devel
>
>
>
> _______________________________________________
> Paparazzi-devel mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/paparazzi-devel
>
>
>
> _______________________________________________
> Paparazzi-devel mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/paparazzi-devel
>
>
> _______________________________________________
> Paparazzi-devel mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/paparazzi-devel


_______________________________________________
Paparazzi-devel mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/paparazzi-devel