[paparazzi-commits] [paparazzi/paparazzi] 10f310: [abi] fix endless loop if AbiBindMsgX is called tw...

[GitHub]

  Branch: refs/heads/fix_multiple_abi_binds
  Home:   https://github.com/paparazzi/paparazzi
  Commit: 10f31013dc21037973d6a08d3fd9ff42e1fdf0fc
      
https://github.com/paparazzi/paparazzi/commit/10f31013dc21037973d6a08d3fd9ff42e1fdf0fc
  Author: Felix Ruess <address@hidden>
  Date:   2016-11-02 (Wed, 02 Nov 2016)

  Changed paths:
    M sw/tools/generators/gen_abi.ml

  Log Message:
  -----------
  [abi] fix endless loop if AbiBindMsgX is called twice for same event

AbiBindMsgX should be called only once per abi_event struct.
Regardless, this tries to make it a bit more robust if you re-use the same 
abi_event for consecutive AbiBindMsgX calls:
If AbiBindMsgX is called multiple times _consecutively_, the event/callback is 
now only added if it is different from the last one added...
This should at least fix the endless loop since the event->next can't point to 
itself anymore...

Should fix #1924 in a rudimentary way... but would still be possible to bind 
multiple times using the same abi_event if another bind for the same message 
happens in between.
Bottom line: make sure that your code doesn't call AbiBindMsg with the same 
abi_event struct multiple times!