Re: [osip-dev] eXosip_call_build_prack

[Aymeric Moizard]

No problem ;)

I was checking the last fix and ... it happens to be necessary for an empty rseq header.

http://git.savannah.gnu.org/cgit/exosip.git/commit/src/eXcall_api.c?id=2a3bb7d8844b8370cb2ae14b2581344b350ba48f

Regards

Aymeric

2015-02-23 13:16 GMT+01:00 FEICHTER Christoph <address@hidden>:

sorry for my last message.

please forget it – was a version-mistake on my side.

 

br,

christoph

 

_____________________________________________
From: FEICHTER Christoph
Sent: Montag, 23. Februar 2015 13:06
To: address@hidden
Subject: eXosip_call_build_prack

 

 

hi,

 

I think that the function eXosip_call_build_prack is not fully RFC 3262 conform.

It should not be possible to generate a PRACK request, which has no RAck header !

 

currently this is possible, due to this section (eXcall_api.c, line 1097ff):

 

	osip_message_header_get_byname(tr->last_response, "RSeq", 0, &rseq);
	if (rseq != NULL && rseq->hvalue != NULL) {
	char tmp[128];
	memset(tmp, '\0', sizeof(tmp));
	snprintf(tmp, 127, "%s %s %s", rseq->hvalue,
	tr->orig_request->cseq->number, tr->orig_request->cseq->method);
	osip_message_set_header(*prack, "RAck", tmp);
	}
	return OSIP_SUCCESS;

 

the implementation has been different before.

this check was the right implementation – which has been removed:

 

  osip_message_header_get_byname (tr->last_response, "RSeq", 0, &rseq);

  if (rseq == NULL || rseq->hvalue == NULL) {

    return OSIP_WRONG_FORMAT;

  }

 

If there is no RSeq header found in the last INVITE-response,

a PRACK cannot be built.

 

br,

christoph

 

 

_______________________________________________
osip-dev mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/osip-dev

--

Antisip - http://www.antisip.com