Re: [osip-dev] WSACleanup missing

[Aymeric Moizard]

I don't think this can be integrated without breaking some existing

applications. A clean change would be to remove the WSAStartup

which would also break apps...

So... I prefer to keep everything unchanged on that topic!

Rejected ;(

Not your fault ;)

Aymeric

2014-12-22 12:25 GMT+01:00 FEICHTER Christoph <address@hidden>:

hi aymeric,

 

one more improvement for eXosip:

since eXosip calls WSAStartup, but never WSACleanup, this causes a memory/handle leak.

 

I would suggest to add the following in eXosip_quit:

 

  …

  eXtl_udp.tl_free (excontext);

  eXtl_tcp.tl_free (excontext);

#ifdef HAVE_OPENSSL_SSL_H

#if !(OPENSSL_VERSION_NUMBER < 0x00908000L)

  eXtl_dtls.tl_free (excontext);

#endif

  eXtl_tls.tl_free (excontext);

#endif

 

  memset (excontext, 0, sizeof (eXosip_t));

  excontext->j_stop_ua = -1;

 

#ifdef WIN32

   WSACleanup();

#endif

 

  return;

}

 

br,

Christoph

 

 

_______________________________________________
osip-dev mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/osip-dev

--

Antisip - http://www.antisip.com