[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Openexr-devel] IlmImf/ImfSystemSpecific.cpp and cpuid
From: |
Ed Hanway |
Subject: |
Re: [Openexr-devel] IlmImf/ImfSystemSpecific.cpp and cpuid |
Date: |
Fri, 15 Aug 2014 00:12:57 +0000 |
I've put the cpuid issue into github to track:
https://github.com/openexr/openexr/issues/128
It'll take a little tweak to your patch because there are old versions of gcc
still in play that don't
provide <cpuid.h>.
-----Original Message-----
From: address@hidden [mailto:address@hidden On Behalf Of Richard PALO
Sent: Wednesday, August 13, 2014 10:06 AM
To: address@hidden
Subject: [Openexr-devel] IlmImf/ImfSystemSpecific.cpp and cpuid
Hi, came across build issues and the above file..
In particular, it fails when building PIC as the asm code doesn't deal with all
the possible cases...
Fortunately the code was already strobed with __GNUC__, so I updated to use the
gcc builtin __get_cpuid which does all the work.
I took advantage of the occasion to rectify the ints to be unsigned as we're
dealing with registers here.
Patch proposal is attached.
Wanting to test this, I came across an issue here as well for SunOS, so I add
as well a second patch to correctly include unistd.h for this platform in
IlmImfTest/main.cpp.
Unfortunately the test fails anyway as there is a file not found named
'comp_dwaa_v1.exr'. Can't seem to find it anywhere. Any hints?
cheers