[Octave-patch-tracker] [patch #9743] [octave forge] (statistics) silhouette function

[Philip Nienhuis]

Follow-up Comment #5, patch #9743 (project octave):

Thanks.

* did you ask the original author if he/she agrees with absorbing his/her work
into Octave's statistics package? It's GPL 3 so not strictly needed but I find
it polite to do so. If you didn't yet, I'll ask.
* I ran the silhouette demo in Octave and Matlab, see attached pic. There are
differences, is there a reason to worry? (again, I have no clue, just asking
you as the expert)
* I ran the examples on the matlab doc page, all examples gave small
differences with ML's output. Again, significant?
* The 4th and last example gave an error in Octave-7.0.0:

>> s1 = silhouette(X,clust,chiSqrDist,w)
error: binary operator '*' not implemented for 'matrix' by 'cell' operations
error: called from
    @<anonymous> at line 1 column 22
    pdist at line 197 column 18
    silhouette at line 119 column 16


Could also be a bug in pdist. So I started digging and the result made me
suspect that pdist.m gets fed an improper argument shape (i.e., from
silhouette.m).  If so I'd think pdist.m also needs stricter input validation,
but I have no time now to dive into it.


(file #51055)
    _______________________________________________________

Additional Item Attachment:

File name: silhouette_comp-ML-Oct.png     Size:66 KB
   
<https://file.savannah.gnu.org/file/silhouette_comp-ML-Oct.png?file_id=51055>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9743>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/