Re: Problem with Disable Mac App Nap

[Andrew Janke]

On 10/28/19 11:57 PM, Ben Abbott wrote:
> 
>> On Oct 28, 2019, at 8:21 PM, Andrew Janke <address@hidden> wrote:
>>
>>
>> On 10/28/19 11:16 PM, Ben Abbott wrote:
>>> Hi Andrew,
>>>
>>> After changeset 27575:d0fe6e344c41 I’m seeing the error below (macOS 
>>> 10.14.6)
>>>
>>> libgui/src/octave-qobject.cc:197:26: warning: use of old-style cast 
>>> [-Wold-style-cast]
>>>    process_info_class = (Class) objc_getClass ("NSProcessInfo");
>>>                         ^       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> libgui/src/octave-qobject.cc:210:39: warning: use of old-style cast 
>>> [-Wold-style-cast]
>>>    if ((process_info = objc_msgSend ((id)process_info_class, 
>>> process_info_selector)) == nil)
>>>                                      ^   ~~~~~~~~~~~~~~~~~~
>>> libgui/src/octave-qobject.cc:213:21: error: no matching function for call 
>>> to 'objc_msgSend'
>>>    reason_string = objc_msgSend (objc_getClass ("NSString"),
>>>                    ^~~~~~~~~~~~
>>> /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/objc/message.h:85:1:
>>>  note: candidate function not viable: no known conversion from 'Class 
>>> _Nullable' (aka 'objc_class *') to
>>>      'id _Nullable' (aka 'objc_object *') for 1st argument
>>> objc_msgSend(id _Nullable self, SEL _Nonnull op, ...)
>>> ^
>>> libgui/src/octave-qobject.cc:222:5: error: use of undeclared identifier 
>>> 'osx_latencycritical_activity'
>>>    osx_latencycritical_activity = objc_msgSend (process_info,
>>>
>>>
>>> Ben
>>
>> Argh. macOS 10.14.6 is what I tested it on in the first place.
>>
>> Out of curiosity, what Xcode version? Not that I was expecting this to
>> happen; the Stack Overflow answer I sourced this from was supposed to be
>> compatible going back many macOS versions.
>>
>> Best revert the change. I don't think I have a way of tracking down
>> what's causing this error.
>>
>> Cheers,
>> Andrew
> 
> About -> Version 11.1
> 
> If it works for you on macOS 10.14.6, it should work for me as well.
> 
> Before reverting, let’s wait for others to try. Maybe something is wrong on 
> my end.
> 
> Ben

I can reproduce the build failure.

Aaaaaaand, I remember now: I couldn't get a good test in the first place
due to unrelated build failures. (See
https://savannah.gnu.org/bugs/?55940#comment50.) So I bet it's broken
for everyone.

I've asked for a revert.
https://savannah.gnu.org/bugs/index.php?55940#comment52

Cheers,
Andrew