octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: diffs to port code to gcc 6


From: Rik
Subject: Re: diffs to port code to gcc 6
Date: Mon, 12 Aug 2019 16:32:32 -0700

Mike,

One question about this diff:

diff --git a/src/ov-class.cc b/src/ov-class.cc
--- a/src/ov-class.cc
+++ b/src/ov-class.cc
@@ -1195,7 +1195,7 @@
       bool b = save_ascii_data (os, val, m.key (i), false, 0);
 
       if (! b)
-        return os;
+        return ! os.fail ();
 
       i++;
     }
@@ -1326,7 +1326,7 @@
       bool b = save_binary_data (os, val, m.key (i), "", 0, save_as_floats);
 
       if (! b)
-        return os;
+        return !!os;
 
       i++;
     }

In all other cases throughout the diff file, "return os;" has been
translated to "return ! os.fail ();".  Is there a reason this single
instance is "return !!os;"?

--Rik

reply via email to

[Prev in Thread] Current Thread [Next in Thread]