octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New notices during bootstrap


From: John W. Eaton
Subject: Re: New notices during bootstrap
Date: Fri, 19 Oct 2018 00:31:44 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 10/18/2018 11:50 AM, Rik wrote:

Second, notice is this one

Notice from module localcharset:
   If your package's tests make use of the locale_charset() function directly or
   indirectly, you may need to define the CHARSETALIASDIR environment variable,
   so that "make check" works before "make install". In Makefile.am syntax:
   TESTS_ENVIRONMENT += @LOCALCHARSET_TESTS_ENVIRONMENT@

Octave does use the wrapped locale_charset() function directly in 4 places:

libinterp/corefcn/strfns.cc:760:    = (tmp.empty () ?
octave_locale_charset_wrapper () : tmp.c_str ());
libinterp/corefcn/strfns.cc:812:    = (tmp.empty () ?
octave_locale_charset_wrapper () : tmp.c_str ());
libinterp/corefcn/input.cc:539:              ?
octave_locale_charset_wrapper () : m_mfile_encoding;
libinterp/corefcn/input.cc:1121:         ? octave_locale_charset_wrapper ()
: mfile_encoding);

I don't whether this is a problem or not.

I don't see anywhere in the Octave sources (from hg or generated by the build) that TESTS_ENVIRONMENT or LOCALCHARSET_TESTS_ENVIRONMENT is used. So I think we can ignore this one.

jwe




reply via email to

[Prev in Thread] Current Thread [Next in Thread]