octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: pending dataframe-1.2.0 release


From: depuis
Subject: Re: pending dataframe-1.2.0 release
Date: Thu, 24 Aug 2017 08:30:05 +0200
User-agent: Scarlet Webmail

On Wed, 23 Aug 2017 20:17:36 +0200, Olaf Till wrote:
On Wed, Aug 23, 2017 at 05:45:43PM +0200, depuis wrote:
On Tue, 22 Aug 2017 15:10:22 +0200, Olaf Till wrote:
>>Calling dataframe_test, lines 191--193 (left division) didn't pass for
>>me without specifying a tolerance...
Could you please tell me if the issue is still present ?

It seems so, with Octave-4.2.1:

FIXME -- should create a dataframe from the whole workspace
error: ASSERT errors for:  assert ((x \ y).array,x.array \ y)

  Location  |  Observed  |  Expected  |  Reason
(1,1) -1.7495 -1.7495 Abs err 4.4409e-16 exceeds tol 0 (2,1) 0.25061 0.25061 Abs err 1.1102e-16 exceeds tol 0 (3,1) -2.1271 -2.1271 Abs err 4.4409e-16 exceeds tol 0 (1,2) 2.1156 2.1156 Abs err 4.4409e-16 exceeds tol 0 (2,2) 0.50236 0.50236 Abs err 3.3307e-16 exceeds tol 0 (3,2) 2.8777 2.8777 Abs err 4.4409e-16 exceeds tol 0 (2,3) 0.053649 0.053649 Abs err 6.9389e-18 exceeds tol 0
Makefile:221: recipe for target 'check' failed


with Octave-4.0.0 only this:

FIXME -- should create a dataframe from the whole workspace
error: ASSERT errors for:  assert ((x \ y).array,x.array \ y)

  Location  |  Observed  |  Expected  |  Reason
(1,1) 0.16759 0.16759 Abs err 5.5511e-17 exceeds tol 0 (2,1) -1.2904 -1.2904 Abs err 4.4409e-16 exceeds tol 0 (3,1) 0.27658 0.27658 Abs err 5.5511e-17 exceeds tol 0
Makefile:221: recipe for target 'check' failed


Pushed a fix for all tests implying left division

>>You probably don't need to upload a further tarball, it should be
>>enough if I generate it at my machine after you've done the last
>>polish to dataframe_test.m
>>
The 'make release' fails in a strange way:
1) it generate the main tarball
2) it fails with the error message 'generate_html not installed'

The Makefile currently has the limitation that _locally_ installed
pre-requisite packages have to be installed _before_ 'make install'
and 'make release'.

To solve the problem, first install generate_html in the usual way,
the type 'make install' and then 'make release'. ('make release' alone
won't re-install the package, unless you delete target/ first).

Tried so, still doesn't work. Could you generate and release the package ?

Regards

Pascal




reply via email to

[Prev in Thread] Current Thread [Next in Thread]