octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Inappropriate usage of pkg-config in acinclude.m4


From: Jordi Gutiérrez Hermoso
Subject: Re: Inappropriate usage of pkg-config in acinclude.m4
Date: Thu, 07 Jul 2016 06:46:36 -0400

On Tue, 2016-07-05 at 00:55 -0700, siko1056 wrote:
> Your recent changeset
> 
> http://hg.savannah.gnu.org/hgweb/octave/rev/a2c29df93df7

Hah, well, I did try to get feedback for it twice before pushing it. I
guess that's the only way to really see what people think about it:
push it anyway and wait for someone to complain about breakage.

I'm glad Mike was able to work out a fix.

I wonder what could we do to foster a better culture of code review
around here. Maybe Phabricator could help?

- Jordi G. H.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]