|
From: | Daniel J Sebald |
Subject: | Re: gplot.txt |
Date: | Fri, 04 Mar 2016 09:40:54 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111108 Fedora/3.1.16-1.fc14 Thunderbird/3.1.16 |
On 03/04/2016 07:44 AM, Ben Abbott wrote:
On Mar 4, 2016, at 07:00, Ben Abbott<address@hidden> wrote:On Mar 4, 2016, at 1:26 AM, Lachlan Andrew<address@hidden> wrote:On 4 March 2016 at 16:37, Daniel J Sebald<address@hidden> wrote: assign memory even from the start--not a bad strategy. However, at that point, the member pointers r and d are initialized as r(0) and d(0). And 2) delete [] r; Now, the first line of code is more questionable. Typically one isn't supposed to delete a NULL pointer.Good catch, but deleting NULL pointers is valid in all standards-compliant compilers, and some people advocate that rather than checking for NULL first. See the discussion at http://stackoverflow.com/questions/4190703/is-it-safe-to-delete-a-null-pointer#4190737 Cheers, LachlanI tried bisecting again. The results I got is below. Many changes needed to be skipped because the default branch wouldn’t build on Mac OS X. Due to skipped revisions, the first bad revision could be any of: changeset: 21210:4f7d3989c462 user: John W. Eaton<address@hidden> date: Sat Feb 06 07:43:32 2016 -0500 summary: move UMFPACK_DNAME and UMFPACK_ZNAME macros to oct-sparse.h changeset: 21211:2cf8bc5c7017 user: John W. Eaton<address@hidden> date: Sat Feb 06 08:48:47 2016 -0500 summary: use "#if defined (HAVE_FOO)" instead of "#if HAVE_FOO" for feature tests changeset: 21212:7eca4ba9bb6d user: John W. Eaton<address@hidden> date: Sat Feb 06 19:18:59 2016 -0500 summary: also distribute octave.css from source tree changeset: 21213:f7d1050b9b53 user: Rik<address@hidden> date: Sat Feb 06 18:22:32 2016 -0800 summary: maint: Clean up various usages of #ifdef. changeset: 21214:7be1f58f9dd7 user: John W. Eaton<address@hidden> date: Sun Feb 07 02:03:58 2016 -0500 summary: don't strip pipe character from command in drawnow function changeset: 21215:04866fac690a user: Ben Abbott<address@hidden> date: Sun Feb 07 02:21:37 2016 -0500 summary: use template keyword to handle dependent template names I’ll try Dan’s patch (since I’m using Apple’s clang, and they often don’t conform to other “standards”. Then I’ll try backingout the above changes until I find the culprit. BenDan's patch didn't resolve the speye segfault. I'll move on to the changesets isolated by bisecting.
OK, thanks Ben. I will follow up with more. Go ahead with bisecting, and I'll approach just from looking at the code.
Dan
[Prev in Thread] | Current Thread | [Next in Thread] |